Changeset 286543 in webkit

Timestamp:

Dec 6, 2021, 6:35:01 AM (5 years ago)

Author:

Nikolas Zimmermann

Message:

[LBSE] Toggling the Settings -> Enabled LBSE flag has no immediate effect
​https://bugs.webkit.org/show_bug.cgi?id=233871

Reviewed by Rob Buis.

Toggling "Enable layer-based SVG engine" in e.g. MiniBrowser or from JS has no immediate effect.
A relayout is not enough: a full style / render tree rebuild is needed.

Source/WebCore:

Covered by existing tests.

• page/SettingsBase.cpp:

(WebCore::SettingsBase::layerBasedSVGEngineEnabledChanged): Rebuild style / renderers upon changes.

• page/SettingsBase.h:

Source/WTF:

• Scripts/Preferences/WebPreferencesInternal.yaml: When "LayerBasedSVGEngineEnabled" changes call

WebCore::SettingsBase::layerBasedSVGEngineEnabledChanged() to assure the switch from legacy to
LBSE engine and vice-versa is live and doesn't need reloads to take effect.

Location:

trunk/Source

Files:

• WTF/ChangeLog (modified) (1 diff)
• WTF/Scripts/Preferences/WebPreferencesInternal.yaml (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/page/SettingsBase.cpp (modified) (1 diff)
• WebCore/page/SettingsBase.h (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2021-12-06  Nikolas Zimmermann  <nzimmermann@igalia.com>
+
+        [LBSE] Toggling the Settings -> Enabled LBSE flag has no immediate effect
+        https://bugs.webkit.org/show_bug.cgi?id=233871
+
+        Reviewed by Rob Buis.
+
+        Toggling "Enable layer-based SVG engine" in e.g. MiniBrowser or from JS has no immediate effect.
+        A relayout is not enough: a full style / render tree rebuild is needed.
+
+        * Scripts/Preferences/WebPreferencesInternal.yaml: When "LayerBasedSVGEngineEnabled" changes call
+        WebCore::SettingsBase::layerBasedSVGEngineEnabledChanged() to assure the switch from legacy to
+        LBSE engine and vice-versa is live and doesn't need reloads to take effect.
+
 2021-12-06  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml

@@ -451 +451 @@
   humanReadableDescription: "Enable next-generation layer-based SVG Engine (LBSE)"
   condition: ENABLE(LAYER_BASED_SVG_ENGINE)
-  webcoreOnChange: setNeedsRelayoutAllFrames
+  webcoreOnChange: layerBasedSVGEngineEnabledChanged
   defaultValue:
     WebCore:

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-12-06  Nikolas Zimmermann  <nzimmermann@igalia.com>
+
+        [LBSE] Toggling the Settings -> Enabled LBSE flag has no immediate effect
+        https://bugs.webkit.org/show_bug.cgi?id=233871
+
+        Reviewed by Rob Buis.
+
+        Toggling "Enable layer-based SVG engine" in e.g. MiniBrowser or from JS has no immediate effect.
+        A relayout is not enough: a full style / render tree rebuild is needed.
+
+        Covered by existing tests.
+
+        * page/SettingsBase.cpp:
+        (WebCore::SettingsBase::layerBasedSVGEngineEnabledChanged): Rebuild style / renderers upon changes.
+        * page/SettingsBase.h:
+
 2021-12-06  Nikolas Zimmermann  <nzimmermann@igalia.com>
 

trunk/Source/WebCore/page/SettingsBase.cpp

@@ -309 +309 @@
 #endif
 
+#if ENABLE(LAYER_BASED_SVG_ENGINE)
+
+void SettingsBase::layerBasedSVGEngineEnabledChanged()
+{
+    if (!m_page)
+        return;
+
+    for (auto* frame = &m_page->mainFrame(); frame; frame = frame->tree().traverseNext()) {
+        auto* document = frame->document();
+        if (!document)
+            continue;
+
+        auto* documentElement = document->documentElement();
+        if (!documentElement)
+            continue;
+
+        documentElement->invalidateStyleAndRenderersForSubtree();
+        document->scheduleFullStyleRebuild();
+    }
+}
+
+#endif
+
 void SettingsBase::userStyleSheetLocationChanged()
 {

trunk/Source/WebCore/page/SettingsBase.h

@@ -140 +140 @@
     void mockCaptureDevicesEnabledChanged();
 #endif
+#if ENABLE(LAYER_BASED_SVG_ENGINE)
+    void layerBasedSVGEngineEnabledChanged();
+#endif
 
     Page* m_page;