⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 286554 in webkit


Ignore:
Timestamp:
Dec 6, 2021, 11:22:54 AM (5 years ago)
Author:
jonlee@apple.com
Message:

Update GPU Process feature flags
​https://bugs.webkit.org/show_bug.cgi?id=232547
rdar://83905400

Reviewed by Wenson Hsieh.

Source/WTF:

Move features enabled by default to internal. DOM and WebGL are experimental.

  • Scripts/Preferences/WebPreferencesExperimental.yaml:
  • Scripts/Preferences/WebPreferencesInternal.yaml:

Tools:

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args): Update features that are set when using run-webkit-tests --use-gpu-process.

  • WebKitTestRunner/TestOptions.cpp:

(WTR::TestOptions::defaults): Turn off DOM Rendering on layout test bots for the time being.

Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WTF/ChangeLog

    r286543 r286554  
     12021-12-06  Jon Lee  <jonlee@apple.com>
     2
     3        Update GPU Process feature flags
     4        https://bugs.webkit.org/show_bug.cgi?id=232547
     5        rdar://83905400
     6
     7        Reviewed by Wenson Hsieh.
     8
     9        Move features enabled by default to internal. DOM and WebGL are experimental.
     10
     11        * Scripts/Preferences/WebPreferencesExperimental.yaml:
     12        * Scripts/Preferences/WebPreferencesInternal.yaml:
     13
    1142021-12-06  Nikolas Zimmermann  <nzimmermann@igalia.com>
    215

  • trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml

    r286540 r286554  
    362362      default: false
    363363
    364 CaptureVideoInGPUProcessEnabled:
    365   type: bool
    366   humanReadableName: "GPU Process: Video Capture"
    367   humanReadableDescription: "Enable video capture in GPU Process"
    368   webcoreBinding: none
    369   condition: ENABLE(MEDIA_STREAM)
    370   exposed: [ WebKit ]
    371   defaultValue:
    372     WebKit:
    373       default: WebKit::defaultCaptureVideoInGPUProcessEnabled()
    374 
    375364ContactPickerAPIEnabled:
    376365  type: bool
    … …  
    13731362      default: true
    13741363
    1375 UseGPUProcessForCanvasRenderingEnabled:
    1376   type: bool
    1377   humanReadableName: "GPU Process: Canvas Rendering"
    1378   humanReadableDescription: "Enable canvas rendering in GPU Process"
     1364UseGPUProcessForDOMRenderingEnabled:
     1365  type: bool
     1366  humanReadableName: "GPU Process: DOM Rendering"
     1367  humanReadableDescription: "Enable DOM rendering in GPU Process"
    13791368  webcoreBinding: none
    1380   condition: ENABLE(GPU_PROCESS) && !(PLATFORM(GTK) || PLATFORM(WPE))
     1369  condition: ENABLE(GPU_PROCESS)
    13811370  exposed: [ WebKit ]
    13821371  defaultValue:
    13831372    WebKit:
    1384       default: defaultUseGPUProcessForCanvasRenderingEnabled()
    1385 
    1386 UseGPUProcessForMediaEnabled:
    1387   type: bool
    1388   humanReadableName: "GPU Process: Media"
    1389   humanReadableDescription: "Do all media loading and playback in the GPU Process"
    1390   webcoreBinding: none
    1391   condition: ENABLE(GPU_PROCESS) && !USE(GSTREAMER)
    1392   exposed: [ WebKit ]
    1393   defaultValue:
    1394     WebKit:
    1395       default: WebKit::defaultUseGPUProcessForMediaEnabled()
     1373      default: defaultUseGPUProcessForDOMRenderingEnabled()
    13961374
    13971375UseGPUProcessForWebGLEnabled:
    … …  
    16411619      default: false
    16421620
    1643 # FIXME: This is not relevent for WebKitLegacy, so should be excluded from WebKitLegacy entirely.
    1644 WebRTCPlatformCodecsInGPUProcessEnabled:
    1645   type: bool
    1646   humanReadableName: "WebRTC Platform Codecs in GPU Process"
    1647   humanReadableDescription: "Enable WebRTC Platform Codecs in GPU Process"
    1648   condition: ENABLE(WEB_RTC)
    1649   defaultValue:
    1650     WebKitLegacy:
    1651       default: false
    1652     WebKit:
    1653       default: WebKit::defaultWebRTCCodecsInGPUProcess()
    1654     WebCore:
    1655       default: false
    1656 
    16571621WebRTCPlatformTCPSocketsEnabled:
    16581622  type: bool

  • trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml

    r286543 r286554  
    155155      default: WebKit::defaultCaptureAudioInUIProcessEnabled()
    156156
     157CaptureVideoInGPUProcessEnabled:
     158  type: bool
     159  humanReadableName: "GPU Process: Video Capture"
     160  humanReadableDescription: "Enable video capture in GPU Process"
     161  webcoreBinding: none
     162  condition: ENABLE(MEDIA_STREAM)
     163  exposed: [ WebKit ]
     164  defaultValue:
     165    WebKit:
     166      default: WebKit::defaultCaptureVideoInGPUProcessEnabled()
     167
    157168CaptureVideoInUIProcessEnabled:
    158169  type: bool
    … …  
    834845      default: true
    835846
    836 UseGPUProcessForDOMRenderingEnabled:
    837   type: bool
    838   humanReadableName: "GPU Process: DOM Rendering"
    839   humanReadableDescription: "Enable DOM rendering in GPU Process"
    840   webcoreBinding: none
    841   condition: ENABLE(GPU_PROCESS)
    842   exposed: [ WebKit ]
    843   defaultValue:
    844     WebKit:
    845       default: defaultUseGPUProcessForDOMRenderingEnabled()
     847UseGPUProcessForCanvasRenderingEnabled:
     848  type: bool
     849  humanReadableName: "GPU Process: Canvas Rendering"
     850  humanReadableDescription: "Enable canvas rendering in GPU Process"
     851  webcoreBinding: none
     852  condition: ENABLE(GPU_PROCESS) && !(PLATFORM(GTK) || PLATFORM(WPE))
     853  exposed: [ WebKit ]
     854  defaultValue:
     855    WebKit:
     856      default: defaultUseGPUProcessForCanvasRenderingEnabled()
     857
     858UseGPUProcessForMediaEnabled:
     859  type: bool
     860  humanReadableName: "GPU Process: Media"
     861  humanReadableDescription: "Do all media loading and playback in the GPU Process"
     862  webcoreBinding: none
     863  condition: ENABLE(GPU_PROCESS) && !USE(GSTREAMER)
     864  exposed: [ WebKit ]
     865  defaultValue:
     866    WebKit:
     867      default: WebKit::defaultUseGPUProcessForMediaEnabled()
    846868
    847869UseSceneKitForModel:
    … …  
    929951    WebKit:
    930952      default: true
     953
     954# FIXME: This is not relevant for WebKitLegacy, so should be excluded from WebKitLegacy entirely.
     955WebRTCPlatformCodecsInGPUProcessEnabled:
     956  type: bool
     957  humanReadableName: "GPU Process: WebRTC Platform Codecs"
     958  humanReadableDescription: "Enable WebRTC Platform Codecs in GPU Process"
     959  condition: ENABLE(WEB_RTC)
     960  defaultValue:
     961    WebKitLegacy:
     962      default: false
     963    WebKit:
     964      default: WebKit::defaultWebRTCCodecsInGPUProcess()
     965    WebCore:
     966      default: false
    931967
    932968WebSQLEnabled:

  • trunk/Tools/ChangeLog

    r286552 r286554  
     12021-12-06  Jon Lee  <jonlee@apple.com>
     2
     3        Update GPU Process feature flags
     4        https://bugs.webkit.org/show_bug.cgi?id=232547
     5        rdar://83905400
     6
     7        Reviewed by Wenson Hsieh.
     8
     9        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
     10        (parse_args): Update features that are set when using `run-webkit-tests --use-gpu-process`.
     11        * WebKitTestRunner/TestOptions.cpp:
     12        (WTR::TestOptions::defaults): Turn off DOM Rendering on layout test bots for the time being.
     13
    1142021-12-06  Matt Gilligan  <matthew_gilligan@apple.com>
    215

  • trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py

    r285132 r286554  
    375375        if not options.internal_feature:
    376376            options.internal_feature = []
    377         options.internal_feature.append('UseGPUProcessForMediaEnabled')
    378377        options.internal_feature.append('CaptureAudioInGPUProcessEnabled')
    379378        options.internal_feature.append('CaptureVideoInGPUProcessEnabled')
    380379        options.internal_feature.append('UseGPUProcessForCanvasRenderingEnabled')
    381         options.internal_feature.append('UseGPUProcessForDOMRenderingEnabled')
     380        options.internal_feature.append('UseGPUProcessForMediaEnabled')
     381        options.internal_feature.append('WebRTCPlatformCodecsInGPUProcessEnabled')
    382382        if not options.experimental_feature:
    383383            options.experimental_feature = []
    384         options.experimental_feature.append('WebRTCPlatformCodecsInGPUProcessEnabled')
     384        options.experimental_feature.append('UseGPUProcessForDOMRenderingEnabled')
    385385        options.experimental_feature.append('UseGPUProcessForWebGLEnabled')
    386386        if options.result_report_flavor:

  • trunk/Tools/WebKitTestRunner/TestOptions.cpp

    r284765 r286554  
    125125            { "VP9DecoderEnabled", false },
    126126#endif
     127#if ENABLE(GPU_PROCESS)
     128            { "UseGPUProcessForDOMRenderingEnabled", false },
     129#endif
    127130#if ENABLE(GPU_PROCESS) && ENABLE(WEBGL)
    128131            { "UseGPUProcessForWebGLEnabled", false },
Note: See TracChangeset for help on using the changeset viewer.