Changeset 286565 in webkit

Timestamp:

Dec 6, 2021, 1:15:39 PM (5 years ago)

Author:

Simon Fraser

Message:

Add a call to os_signpost to tag a momentum scroll animation
​https://bugs.webkit.org/show_bug.cgi?id=233885

Reviewed by Tim Horton.

Source/WebCore:

Use the momentum "Began" and "Ended" events to mark the start/end of a momentum scroll
as an animation via os_signost.

Put the code in ScrollingEffectsController rather than MomentumEventDispatcher so that
non-generated momentum gets marked too.

• platform/mac/ScrollingEffectsController.mm:

(WebCore::ScrollingEffectsController::handleWheelEvent):

Source/WTF:

• wtf/SystemTracing.h:

Location:

trunk/Source

Files:

• WTF/ChangeLog (modified) (1 diff)
• WTF/wtf/SystemTracing.h (modified) (3 diffs)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/mac/ScrollingEffectsController.mm (modified) (3 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2021-12-06  Simon Fraser  <simon.fraser@apple.com>
+
+        Add a call to os_signpost to tag a momentum scroll animation
+        https://bugs.webkit.org/show_bug.cgi?id=233885
+
+        Reviewed by Tim Horton.
+
+        * wtf/SystemTracing.h:
+
 2021-12-06  Antoine Quint  <graouts@webkit.org>
 

trunk/Source/WTF/wtf/SystemTracing.h

@@ -197 +197 @@
 WTF_EXTERN_C_END
 
+// These macros only emit signposts on internal builds when WEBKIT_SIGNPOSTS_ENABLED is set.
 #define WTFEmitSignpost(pointer, name, ...) \
     WTFEmitSignpostWithFunction(os_signpost_event_emit, (pointer), name, ##__VA_ARGS__)
@@ -215 +216 @@
 } while (0)
 
+// These macros emit signposts on all builds.
+#define WTFEmitSignpostAlways(name, format, ...) \
+    do { os_signpost_event_emit(WTFSignpostLogHandle(), OS_SIGNPOST_ID_EXCLUSIVE, name, format, ##__VA_ARGS__); } } while (0)
+
+#define WTFBeginSignpostIntervalAlways(name, format, ...) \
+    do { os_signpost_interval_begin(WTFSignpostLogHandle(), OS_SIGNPOST_ID_EXCLUSIVE, name, format, ##__VA_ARGS__); } while (0)
+
+#define WTF_OS_SIGNPOST_ANIMATION_INTERVAL_TAG "isAnimation=YES"
+
+#define WTFBeginAnimationSignpostIntervalAlways(name, format, ...) \
+    do { os_signpost_interval_begin(WTFSignpostLogHandle(), OS_SIGNPOST_ID_EXCLUSIVE, name, format " " WTF_OS_SIGNPOST_ANIMATION_INTERVAL_TAG, ##__VA_ARGS__); } while (0)
+
+#define WTFEndSignpostIntervalAlways(name, format, ...) \
+    do { os_signpost_interval_end(WTFSignpostLogHandle(), OS_SIGNPOST_ID_EXCLUSIVE, name, format, ##__VA_ARGS__); } while (0)
+
 #else
 
@@ -221 +237 @@
 #define WTFEndSignpost(pointer, name, ...) do { } while (0)
 
+#define WTFEmitSignpostAlways(name, format, ...) do { } while (0)
+#define WTFBeginSignpostIntervalAlways(name, format, ...) do { } while (0)
+#define WTFBeginAnimationSignpostIntervalAlways(name, format, ...) do { } while (0)
+#define WTFEndSignpostIntervalAlways(name, format, ...) do { } while (0)
+
 #endif

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-12-06  Simon Fraser  <simon.fraser@apple.com>
+
+        Add a call to os_signpost to tag a momentum scroll animation
+        https://bugs.webkit.org/show_bug.cgi?id=233885
+
+        Reviewed by Tim Horton.
+
+        Use the momentum "Began" and "Ended" events to mark the start/end of a momentum scroll
+        as an animation via os_signost.
+
+        Put the code in ScrollingEffectsController rather than MomentumEventDispatcher so that
+        non-generated momentum gets marked too.
+
+        * platform/mac/ScrollingEffectsController.mm:
+        (WebCore::ScrollingEffectsController::handleWheelEvent):
+
 2021-12-06  Devin Rousso  <drousso@apple.com>
 

trunk/Source/WebCore/platform/mac/ScrollingEffectsController.mm

@@ -35 +35 @@
 #import <sys/sysctl.h>
 #import <sys/time.h>
+#import <wtf/SystemTracing.h>
 #import <wtf/text/TextStream.h>
 
@@ -178 +179 @@
 
     auto momentumPhase = wheelEvent.momentumPhase();
+    
+    if (momentumPhase == PlatformWheelEventPhase::Began)
+        WTFBeginAnimationSignpostIntervalAlways("Momentum scroll", "");
+    
     if (!m_momentumScrollInProgress && (momentumPhase == PlatformWheelEventPhase::Began || momentumPhase == PlatformWheelEventPhase::Changed))
         m_momentumScrollInProgress = true;
@@ -220 +225 @@
 
     if (m_momentumScrollInProgress && momentumPhase == PlatformWheelEventPhase::Ended) {
+        WTFEndSignpostIntervalAlways("Momentum scroll", "");
         m_momentumScrollInProgress = false;
         m_ignoreMomentumScrolls = false;