Changeset 286566 in webkit

Timestamp:

Dec 6, 2021, 1:31:41 PM (5 years ago)

Author:

timothy_horton@apple.com

Message:

Momentum Event Dispatcher: Momentum phase runs backwards with natural scrolling disabled
​https://bugs.webkit.org/show_bug.cgi?id=233894
<rdar://problem/86111948>

Reviewed by Simon Fraser.

• WebProcess/WebPage/MomentumEventDispatcher.cpp:

(WebKit::MomentumEventDispatcher::consumeDeltaForCurrentTime):
Only flip the deltas if the trackpad is configured to use "natural"
scrolling (in which "directionInvertedFromDevice" is true).

(WebKit::MomentumEventDispatcher::computeNextDelta):
Fix initial queue state logging to log both axes before setting the "did log" bit.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/WebPage/MomentumEventDispatcher.cpp (modified) (3 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-12-06  Tim Horton  <timothy_horton@apple.com>
+
+        Momentum Event Dispatcher: Momentum phase runs backwards with natural scrolling disabled
+        https://bugs.webkit.org/show_bug.cgi?id=233894
+        <rdar://problem/86111948>
+
+        Reviewed by Simon Fraser.
+
+        * WebProcess/WebPage/MomentumEventDispatcher.cpp:
+        (WebKit::MomentumEventDispatcher::consumeDeltaForCurrentTime):
+        Only flip the deltas if the trackpad is configured to use "natural"
+        scrolling (in which "directionInvertedFromDevice" is true).
+
+        (WebKit::MomentumEventDispatcher::computeNextDelta):
+        Fix initial queue state logging to log both axes before setting the "did log" bit.
+
 2021-12-06  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp

@@ -307 +307 @@
     m_currentGesture.currentOffset += delta;
 
-    return -delta;
+    if (m_currentGesture.initiatingEvent->directionInvertedFromDevice())
+        delta.scale(-1);
+
+    return delta;
 }
 
@@ -479 +482 @@
 
 #if ENABLE(MOMENTUM_EVENT_DISPATCHER_TEMPORARY_LOGGING)
-        if (!m_currentGesture.didLogInitialQueueState) {
+        if (!m_currentGesture.didLogInitialQueueState)
             RELEASE_LOG(ScrollAnimations, "MomentumEventDispatcher initial historical deltas: average delta %f, average time %fms, event count %d", averageDelta, averageFrameIntervalMS, count);
-            m_currentGesture.didLogInitialQueueState = true;
-        }
 #endif
 
@@ -503 +504 @@
     );
 
+#if ENABLE(MOMENTUM_EVENT_DISPATCHER_TEMPORARY_LOGGING)
+    m_currentGesture.didLogInitialQueueState = true;
+#endif
+
     return { unacceleratedDelta, acceleratedDelta };
 }