Changeset 286574 in webkit

Timestamp:

Dec 6, 2021, 3:37:28 PM (5 years ago)

Author:

Chris Dumez

Message:

Regression(r286505) imported/w3c/web-platform-tests/html/cross-origin-opener-policy/javascript-url.https.html is a flaky crash
​https://bugs.webkit.org/show_bug.cgi?id=233874

Reviewed by Darin Adler.

r286505 fixed ProvisionalPageProxy so that ProvisionalPageProxy::m_provisionalLoadURL gets properly initialized when the
ProvisionalPageProxy gets constructed *after* the provisional load has already started (COOP proces-swap case). One side
effect of this though is that ProvisionalPageProxy::cancel() no longer returns early and will try to notify the client
that the provisional load failed, dereferencing m_mainFrame in doing so. In the event where the main frame has not yet
been created in the new provisional process, this would do a null-dereference of m_mainFrame.

To address the issue, we now early return in ProvisionalPageProxy::cancel() if m_isProcessSwappingOnNavigationResponse
is true (i.e. The ProvisionalPageProxy was created after the provisional load had started). In such situations, we
don't want to ProvisionalPageProxy to be the one notifying the client of the provisional load failure anyway. The reason
is that there is still a provisional load going on in the committed process/page.

No new tests, covered by existing test that is flakily crashing.

• UIProcess/ProvisionalPageProxy.cpp:

(WebKit::ProvisionalPageProxy::cancel):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ProvisionalPageProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-12-06  Chris Dumez  <cdumez@apple.com>
+
+        Regression(r286505) imported/w3c/web-platform-tests/html/cross-origin-opener-policy/javascript-url.https.html is a flaky crash
+        https://bugs.webkit.org/show_bug.cgi?id=233874
+
+        Reviewed by Darin Adler.
+
+        r286505 fixed ProvisionalPageProxy so that ProvisionalPageProxy::m_provisionalLoadURL gets properly initialized when the
+        ProvisionalPageProxy gets constructed *after* the provisional load has already started (COOP proces-swap case). One side
+        effect of this though is that ProvisionalPageProxy::cancel() no longer returns early and will try to notify the client
+        that the provisional load failed, dereferencing m_mainFrame in doing so. In the event where the main frame has not yet
+        been created in the new provisional process, this would do a null-dereference of m_mainFrame.
+
+        To address the issue, we now early return in ProvisionalPageProxy::cancel() if m_isProcessSwappingOnNavigationResponse
+        is true (i.e. The ProvisionalPageProxy was created after the provisional load had started). In such situations, we
+        don't want to ProvisionalPageProxy to be the one notifying the client of the provisional load failure anyway. The reason
+        is that there is still a provisional load going on in the committed process/page.
+        
+        No new tests, covered by existing test that is flakily crashing.
+
+        * UIProcess/ProvisionalPageProxy.cpp:
+        (WebKit::ProvisionalPageProxy::cancel):
+
 2021-12-06  Ryan Haddad  <ryanhaddad@apple.com>
 

trunk/Source/WebKit/UIProcess/ProvisionalPageProxy.cpp

@@ -144 +144 @@
 {
     // If the provisional load started, then indicate that it failed due to cancellation by calling didFailProvisionalLoadForFrame().
-    if (m_provisionalLoadURL.isEmpty())
-        return;
-        
+    if (m_provisionalLoadURL.isEmpty() || m_isProcessSwappingOnNavigationResponse)
+        return;
+
     ASSERT(m_process->state() == WebProcessProxy::State::Running);