Changeset 286582 in webkit

Timestamp:

Dec 6, 2021, 5:19:58 PM (5 years ago)

Author:

wilander@apple.com

Message:

Add WebCore::RegistrableDomain tests for duplicate sub domains
​https://bugs.webkit.org/show_bug.cgi?id=233902
<rdar://problem/86130326>

Unreviewed expansion of the RegistrableDomain.MatchesURLs API test.

​https://bugs.webkit.org/show_bug.cgi?id=233330 claims that duplicate sub domains
such as news.news.example.com causes WebKit's RegistrableDomain matching to fail
and treat same-site content as cross-site. This patch add tests of such duplicate
sub domains.

• TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:

(TestWebKitAPI::TEST):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2021-12-06  John Wilander  <wilander@apple.com>
+
+        Add WebCore::RegistrableDomain tests for duplicate sub domains
+        https://bugs.webkit.org/show_bug.cgi?id=233902
+        <rdar://problem/86130326>
+
+        Unreviewed expansion of the RegistrableDomain.MatchesURLs API test.
+
+        https://bugs.webkit.org/show_bug.cgi?id=233330 claims that duplicate sub domains
+        such as news.news.example.com causes WebKit's RegistrableDomain matching to fail
+        and treat same-site content as cross-site. This patch add tests of such duplicate
+        sub domains.
+
+        * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
+        (TestWebKitAPI::TEST):
+
 2021-12-06  Brady Eidson  <beidson@apple.com>
 

trunk/Tools/TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp

@@ -59 +59 @@
     URL webkitURLWithPath { URL(), "https://webkit.org/road/to/nowhere/" };
     URL webkitSubdomainURL { URL(), "https://sub.domain.webkit.org" };
+    URL webkitOtherSubdomainURL { URL(), "https://sub.other.webkit.org" };
+    URL webkitDuplicateSubdomainURL { URL(), "https://domain.domain.webkit.org" };
     URL webkitSubdomainURLWithPath { URL(), "https://sub.domain.webkit.org/road/to/nowhere/" };
     RegistrableDomain webkitDomain { webkitURL };
+    RegistrableDomain webkitSubdomain { webkitSubdomainURL };
 
     ASSERT_TRUE(webkitDomain.matches(webkitURL));
     ASSERT_TRUE(webkitDomain.matches(webkitURLWithPath));
     ASSERT_TRUE(webkitDomain.matches(webkitSubdomainURL));
+    ASSERT_TRUE(webkitDomain.matches(webkitDuplicateSubdomainURL));
     ASSERT_TRUE(webkitDomain.matches(webkitSubdomainURLWithPath));
+    ASSERT_TRUE(webkitSubdomain.matches(webkitOtherSubdomainURL));
+    ASSERT_TRUE(webkitSubdomain.matches(webkitDuplicateSubdomainURL));
 
     URL localhostURL { URL(), "http://localhost" };