Changeset 286590 in webkit


Ignore:
Timestamp:
Dec 6, 2021 11:30:07 PM (2 years ago)
Author:
pvollan@apple.com
Message:

[iOS] Remove mach service extensions for the WebContent process
​https://bugs.webkit.org/show_bug.cgi?id=232952
<rdar://problem/85259753>

Reviewed by Brent Fulgham.

Remove mach service extensions for the WebContent process, which we think are no longer needed, based on local testing.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):
(WebKit::nonBrowserServices): Deleted.

  • UIProcess/WebPageProxy.cpp:

(WebKit::attachmentElementServices):

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

Location:
trunk/Source/WebKit
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r286588 r286590  
     12021-12-06  Per Arne  <pvollan@apple.com>
     2
     3        [iOS] Remove mach service extensions for the WebContent process
     4        https://bugs.webkit.org/show_bug.cgi?id=232952
     5        <rdar://problem/85259753>
     6
     7        Reviewed by Brent Fulgham.
     8
     9        Remove mach service extensions for the WebContent process, which we think are no longer needed, based on local testing.
     10
     11        * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
     12        * Shared/WebProcessCreationParameters.cpp:
     13        (WebKit::WebProcessCreationParameters::encode const):
     14        (WebKit::WebProcessCreationParameters::decode):
     15        * Shared/WebProcessCreationParameters.h:
     16        * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
     17        (WebKit::WebProcessPool::platformInitializeWebProcess):
     18        (WebKit::nonBrowserServices): Deleted.
     19        * UIProcess/WebPageProxy.cpp:
     20        (WebKit::attachmentElementServices):
     21        * WebProcess/cocoa/WebProcessCocoa.mm:
     22        (WebKit::WebProcess::platformInitializeWebProcess):
     23
    1242021-12-06  Patrick Angle  <pangle@apple.com>
    225

  • trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in

    r286557 r286590  
    11241124        (extension "com.apple.webkit.extension.mach")
    11251125        (global-name
    1126             "com.apple.PowerManagement.control"
    1127             "com.apple.frontboard.systemappservices"
    11281126            "com.apple.iconservices"
    1129             "com.apple.lsd.open"
    11301127        )
    11311128    )

  • trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp

    r286484 r286590  
    172172
    173173#if PLATFORM(IOS_FAMILY)
    174     encoder << dynamicMachExtensionHandles;
    175174    encoder << dynamicIOKitExtensionHandles;
    176175#endif
    … …  
    486485
    487486#if PLATFORM(IOS_FAMILY)
    488     std::optional<Vector<SandboxExtension::Handle>> dynamicMachExtensionHandles;
    489     decoder >> dynamicMachExtensionHandles;
    490     if (!dynamicMachExtensionHandles)
    491         return false;
    492     parameters.dynamicMachExtensionHandles = WTFMove(*dynamicMachExtensionHandles);
    493 
    494487    std::optional<Vector<SandboxExtension::Handle>> dynamicIOKitExtensionHandles;
    495488    decoder >> dynamicIOKitExtensionHandles;

  • trunk/Source/WebKit/Shared/WebProcessCreationParameters.h

    r286484 r286590  
    210210
    211211#if PLATFORM(IOS_FAMILY)
    212     Vector<SandboxExtension::Handle> dynamicMachExtensionHandles;
    213212    Vector<SandboxExtension::Handle> dynamicIOKitExtensionHandles;
    214213#endif

  • trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm

    r286484 r286590  
    283283}
    284284
    285 #if PLATFORM(IOS_FAMILY)
    286 static const Vector<ASCIILiteral>& nonBrowserServices()
    287 {
    288     ASSERT(isMainRunLoop());
    289     static const auto services = makeNeverDestroyed(Vector<ASCIILiteral> {
    290         "com.apple.lsd.open"_s,
    291         "com.apple.iconservices"_s,
    292         "com.apple.PowerManagement.control"_s,
    293         "com.apple.frontboard.systemappservices"_s
    294     });
    295     return services;
    296 }
    297 #endif
    298 
    299285static bool requiresContainerManagerAccess()
    300286{
    … …  
    426412
    427413#if PLATFORM(IOS_FAMILY)
    428     if (!WebCore::IOSApplication::isMobileSafari())
    429         parameters.dynamicMachExtensionHandles = SandboxExtension::createHandlesForMachLookup(nonBrowserServices(), std::nullopt);
    430 
    431414    if (WebCore::deviceHasAGXCompilerService())
    432415        parameters.dynamicIOKitExtensionHandles = SandboxExtension::createHandlesForIOKitClassExtensions(WebCore::agxCompilerClasses(), std::nullopt);

  • trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

    r286557 r286590  
    80168016{
    80178017    static const auto services = makeNeverDestroyed(Vector<ASCIILiteral> {
    8018 #if PLATFORM(IOS_FAMILY)
    8019         "com.apple.frontboard.systemappservices"_s,
    8020 #endif
    80218018        "com.apple.iconservices"_s,
    80228019#if PLATFORM(MAC)

  • trunk/Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm

    r286484 r286590  
    414414   
    415415#if PLATFORM(IOS_FAMILY)
    416     SandboxExtension::consumePermanently(parameters.dynamicMachExtensionHandles);
    417416    SandboxExtension::consumePermanently(parameters.dynamicIOKitExtensionHandles);
    418417#endif
Note: See TracChangeset for help on using the changeset viewer.