Changeset 286604 in webkit

Timestamp:

Dec 7, 2021, 12:11:07 PM (5 years ago)

Author:

Chris Dumez

Message:

Make WebLockRegistryProxy::processDidExit() return early if process never registered any locks
​https://bugs.webkit.org/show_bug.cgi?id=233832

Reviewed by Darin Adler.

Make WebLockRegistryProxy::processDidExit() return early if process never registered any locks.
This avoids calling LocalWebLockRegistry::clientsAreGoingAway() (which can be expensive) in the
case we know for sure no locks were registered by this process.

• UIProcess/WebLockRegistryProxy.cpp:

(WebKit::WebLockRegistryProxy::requestLock):
(WebKit::WebLockRegistryProxy::processDidExit):

• UIProcess/WebLockRegistryProxy.h:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebLockRegistryProxy.cpp (modified) (2 diffs)
• UIProcess/WebLockRegistryProxy.h (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-12-07  Chris Dumez  <cdumez@apple.com>
+
+        Make WebLockRegistryProxy::processDidExit() return early if process never registered any locks
+        https://bugs.webkit.org/show_bug.cgi?id=233832
+
+        Reviewed by Darin Adler.
+
+        Make WebLockRegistryProxy::processDidExit() return early if process never registered any locks.
+        This avoids calling LocalWebLockRegistry::clientsAreGoingAway() (which can be expensive) in the
+        case we know for sure no locks were registered by this process.
+
+        * UIProcess/WebLockRegistryProxy.cpp:
+        (WebKit::WebLockRegistryProxy::requestLock):
+        (WebKit::WebLockRegistryProxy::processDidExit):
+        * UIProcess/WebLockRegistryProxy.h:
+
 2021-12-07  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/UIProcess/WebLockRegistryProxy.cpp

@@ -54 +54 @@
     MESSAGE_CHECK(lockIdentifier.processIdentifier() == m_process.coreProcessIdentifier());
     MESSAGE_CHECK(clientID.processIdentifier() == m_process.coreProcessIdentifier());
+    m_hasEverRequestedLocks = true;
 
     m_process.websiteDataStore().webLockRegistry().requestLock(WTFMove(clientOrigin), lockIdentifier, clientID, WTFMove(name), lockMode, steal, ifAvailable, [weakThis = WeakPtr { *this }, lockIdentifier, clientID](bool success) {
@@ -91 +92 @@
 void WebLockRegistryProxy::processDidExit()
 {
-    m_process.websiteDataStore().webLockRegistry().clientsAreGoingAway(m_process.coreProcessIdentifier());
+    if (m_hasEverRequestedLocks)
+        m_process.websiteDataStore().webLockRegistry().clientsAreGoingAway(m_process.coreProcessIdentifier());
 }
 

trunk/Source/WebKit/UIProcess/WebLockRegistryProxy.h

@@ -58 +58 @@
 
     WebProcessProxy& m_process;
+    bool m_hasEverRequestedLocks { false };
 };