Changeset 286633 in webkit

Timestamp:

Dec 7, 2021, 5:32:10 PM (5 years ago)

Author:

Yousuke.Kimoto@sony.com

Message:

[webkitcorepy] Fail to install python module when a working directory is not on C drive on Windows
​https://bugs.webkit.org/show_bug.cgi?id=233936

Reviewed by Jonathan Bedard.

On Windows, autoinstall.py installs python modules to C drive even if
your working directory is on other drive (e.g. D drive). To install
python modules correctly on Windows, a drive letter where your working
directory exists needs to be given to "--root" option of "setup.py"
in autoinstall.py.

• Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:

(Package.install): Added root_location to detect a right drive letter to isntall modules on Windows.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2021-12-07  Yousuke Kimoto  <Yousuke.Kimoto@sony.com>
+
+        [webkitcorepy] Fail to install python module when a working directory is not on C drive on Windows
+        https://bugs.webkit.org/show_bug.cgi?id=233936
+
+        Reviewed by Jonathan Bedard.
+
+        On Windows, autoinstall.py installs python modules to C drive even if
+        your working directory is on other drive (e.g. D drive). To install
+        python modules correctly on Windows, a drive letter where your working
+        directory exists needs to be given to "--root" option of "setup.py"
+        in autoinstall.py.
+
+        * Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py:
+        (Package.install): Added root_location to detect a right drive letter to isntall modules on Windows.
+
 2021-12-07  Devin Rousso  <drousso@apple.com>
 

trunk/Tools/Scripts/libraries/webkitcorepy/webkitcorepy/autoinstall.py

@@ -306 +306 @@
                     AutoInstall.log('{} is known to be slow to install'.format(archive))
 
+                root_location = "/" if not sys.platform.startswith('win') else "{}/".format(os.path.splitdrive(os.path.abspath(install_location))[0])
+
                 log_location = os.path.join(temp_location, 'log.txt')
                 try:
@@ -315 +317 @@
                                 'install',
                                 '--home={}'.format(install_location),
-                                '--root=/',
+                                '--root={}'.format(root_location),
                                 '--prefix=',
                                 '--install-lib={}'.format(install_location),