Changeset 286643 in webkit

Timestamp:

Dec 7, 2021, 10:34:20 PM (5 years ago)

Author:

graouts@webkit.org

Message:

[Model] Only expose APIs on the IDL interface when the feature is enabled
​https://bugs.webkit.org/show_bug.cgi?id=233942

Reviewed by Dean Jackson.

• Modules/model-element/HTMLModelElement.idl:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/model-element/HTMLModelElement.idl (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-12-07  Antoine Quint  <graouts@webkit.org>
+
+        [Model] Only expose APIs on the IDL interface when the feature is enabled
+        https://bugs.webkit.org/show_bug.cgi?id=233942
+
+        Reviewed by Dean Jackson.
+
+        * Modules/model-element/HTMLModelElement.idl:
+
 2021-12-07  Antoine Quint  <graouts@webkit.org>
 

trunk/Source/WebCore/Modules/model-element/HTMLModelElement.idl

@@ -35 +35 @@
     undefined enterFullscreen();
 
-    Promise<HTMLModelElementCamera> getCamera();
-    Promise<undefined> setCamera(HTMLModelElementCamera camera);
+    [Conditional=ARKIT_INLINE_PREVIEW_CAMERA_TRANSFORM] Promise<HTMLModelElementCamera> getCamera();
+    [Conditional=ARKIT_INLINE_PREVIEW_CAMERA_TRANSFORM] Promise<undefined> setCamera(HTMLModelElementCamera camera);
 
-    Promise<boolean> isPlayingAnimation();
-    Promise<undefined> playAnimation();
-    Promise<undefined> pauseAnimation();
+    [Conditional=ARKIT_INLINE_PREVIEW_ANIMATIONS_CONTROL] Promise<boolean> isPlayingAnimation();
+    [Conditional=ARKIT_INLINE_PREVIEW_ANIMATIONS_CONTROL] Promise<undefined> playAnimation();
+    [Conditional=ARKIT_INLINE_PREVIEW_ANIMATIONS_CONTROL] Promise<undefined> pauseAnimation();
 
-    Promise<boolean> isLoopingAnimation();
-    Promise<undefined> setIsLoopingAnimation(boolean looping);
+    [Conditional=ARKIT_INLINE_PREVIEW_ANIMATIONS_CONTROL] Promise<boolean> isLoopingAnimation();
+    [Conditional=ARKIT_INLINE_PREVIEW_ANIMATIONS_CONTROL] Promise<undefined> setIsLoopingAnimation(boolean looping);
 
-    Promise<double> animationDuration();
-    Promise<double> animationCurrentTime();
-    Promise<undefined> setAnimationCurrentTime(double currentTime);
+    [Conditional=ARKIT_INLINE_PREVIEW_ANIMATIONS_CONTROL] Promise<double> animationDuration();
+    [Conditional=ARKIT_INLINE_PREVIEW_ANIMATIONS_CONTROL] Promise<double> animationCurrentTime();
+    [Conditional=ARKIT_INLINE_PREVIEW_ANIMATIONS_CONTROL] Promise<undefined> setAnimationCurrentTime(double currentTime);
 
-    Promise<boolean> hasAudio();
-    Promise<boolean> isMuted();
-    Promise<undefined> setIsMuted(boolean isMuted);
+    [Conditional=ARKIT_INLINE_PREVIEW_AUDIO_CONTROL] Promise<boolean> hasAudio();
+    [Conditional=ARKIT_INLINE_PREVIEW_AUDIO_CONTROL] Promise<boolean> isMuted();
+    [Conditional=ARKIT_INLINE_PREVIEW_AUDIO_CONTROL] Promise<undefined> setIsMuted(boolean isMuted);
 };