Changeset 286733 in webkit

Timestamp:

Dec 8, 2021, 1:26:29 PM (5 years ago)

Author:

Alan Coon

Message:

Cherry-pick r286631. rdar://problem/85928816

[Scroll Momentum Generator] Pages lose ability to momentum scroll after dragging between displays
​https://bugs.webkit.org/show_bug.cgi?id=233948
rdar://86110813

Reviewed by Tim Horton.

This is a conservative fix for the bug. When a view moves to a new screen, WebPageProxy
needs to unregister for full speed updates using the old displayID, and register
using the new one.

Longer term, it would be better if "full speed updates" was a per-observer concept,
but that would mean registering an observer while wheel events are being received,
which needs a bit more thought.

• UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::windowScreenDidChange):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@286631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-612.4.2.1-branch/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (2 diffs)

branches/safari-612.4.2.1-branch/Source/WebKit/ChangeLog

@@ +1 @@
+2021-12-08  Alan Coon  <alancoon@apple.com>
+
+        Cherry-pick r286631. rdar://problem/85928816
+
+    [Scroll Momentum Generator] Pages lose ability to momentum scroll after dragging between displays
+    https://bugs.webkit.org/show_bug.cgi?id=233948
+    rdar://86110813
+    
+    Reviewed by Tim Horton.
+    
+    This is a conservative fix for the bug. When a view moves to a new screen, WebPageProxy
+    needs to unregister for full speed updates using the old displayID, and register
+    using the new one.
+    
+    Longer term, it would be better if "full speed updates" was a per-observer concept,
+    but that would mean registering an observer while wheel events are being received,
+    which needs a bit more thought.
+    
+    * UIProcess/WebPageProxy.cpp:
+    (WebKit::WebPageProxy::windowScreenDidChange):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286631 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-12-07  Simon Fraser  <simon.fraser@apple.com>
+
+            [Scroll Momentum Generator] Pages lose ability to momentum scroll after dragging between displays
+            https://bugs.webkit.org/show_bug.cgi?id=233948
+            rdar://86110813
+
+            Reviewed by Tim Horton.
+
+            This is a conservative fix for the bug. When a view moves to a new screen, WebPageProxy
+            needs to unregister for full speed updates using the old displayID, and register
+            using the new one.
+
+            Longer term, it would be better if "full speed updates" was a per-observer concept,
+            but that would mean registering an observer while wheel events are being received,
+            which needs a bit more thought.
+
+            * UIProcess/WebPageProxy.cpp:
+            (WebKit::WebPageProxy::windowScreenDidChange):
+
 2021-12-06  Alan Coon  <alancoon@apple.com>
 

branches/safari-612.4.2.1-branch/Source/WebKit/UIProcess/WebPageProxy.cpp

@@ -4003 +4003 @@
 void WebPageProxy::windowScreenDidChange(PlatformDisplayID displayID, std::optional<unsigned> nominalFramesPerSecond)
 {
+#if HAVE(CVDISPLAYLINK)
+    if (hasRunningProcess() && m_displayID && m_registeredForFullSpeedUpdates)
+        process().processPool().setDisplayLinkForDisplayWantsFullSpeedUpdates(*m_process->connection(), *m_displayID, false);
+
+    m_registeredForFullSpeedUpdates = false;
+#endif
+
     m_displayID = displayID;
 
@@ -4010 +4017 @@
     send(Messages::EventDispatcher::PageScreenDidChange(m_webPageID, displayID));
     send(Messages::WebPage::WindowScreenDidChange(displayID, nominalFramesPerSecond));
+#if HAVE(CVDISPLAYLINK)
+    updateDisplayLinkFrequency();
+#endif
 }