Changeset 286779 in webkit

Timestamp:

Dec 9, 2021, 7:33:03 AM (5 years ago)

Author:

dino@apple.com

Message:

[ANGLE] Code generation happens on each build and produces SCM diffs
​https://bugs.webkit.org/show_bug.cgi?id=234025

Reviewed by Kimmo Kinnunen.

Temporarily remove the build phase that generates the
mtl_default_shaders_src_autogen files because they are producing
diffs.

We either need to generate these manually, or fix the Xcode project
to generate them into Derived Sources so they don't appear in our
repository.

• ANGLE.xcodeproj/project.pbxproj:

Location:

trunk/Source/ThirdParty/ANGLE

Files:

• ANGLE.xcodeproj/project.pbxproj (modified) (2 diffs)
• ChangeLog (modified) (1 diff)

trunk/Source/ThirdParty/ANGLE/ANGLE.xcodeproj/project.pbxproj

@@ -3514 +3514 @@
                         buildConfigurationList = FFDA50CB269F845100AE11E2 /* Build configuration list for PBXNativeTarget "ANGLEMetalLib" */;
                         buildPhases = (
-                                FF194FF827443BDF006A97A3 /* ShellScript */,
                                 FFDA50C3269F845100AE11E2 /* Sources */,
                         );
@@ -3586 +3585 @@
                         shellPath = /bin/sh;
                         shellScript = "if [ \"${XCODE_VERSION_ACTUAL}\" -ge \"1140\" -a \"${WK_USE_NEW_BUILD_SYSTEM}\" = \"YES\" ]; then\n    # In this configuration, post-processing is performed at the same time as copying in the postprocess-header-rule script, so there's no need for this separate step.\n    exit 0\nfi\n\nexec \"$SRCROOT/adjust-angle-include-paths.py\"\n";
-                };
-                FF194FF827443BDF006A97A3 /* ShellScript */ = {
-                        isa = PBXShellScriptBuildPhase;
-                        buildActionMask = 2147483647;
-                        files = (
-                        );
-                        inputFileListPaths = (
-                        );
-                        inputPaths = (
-                        );
-                        outputFileListPaths = (
-                        );
-                        outputPaths = (
-                        );
-                        runOnlyForDeploymentPostprocessing = 0;
-                        shellPath = /bin/sh;
-                        shellScript = "python scripts/run_code_generation.py -g \"Metal default shaders\"\nexit 0\n";
                 };
                 FFDA50D5269F895400AE11E2 /* Bake Metal Library to NSData */ = {

trunk/Source/ThirdParty/ANGLE/ChangeLog

@@ +1 @@
+2021-12-09  Dean Jackson  <dino@apple.com>
+
+        [ANGLE] Code generation happens on each build and produces SCM diffs
+        https://bugs.webkit.org/show_bug.cgi?id=234025
+
+        Reviewed by Kimmo Kinnunen.
+
+        Temporarily remove the build phase that generates the
+        mtl_default_shaders_src_autogen files because they are producing
+        diffs.
+
+        We either need to generate these manually, or fix the Xcode project
+        to generate them into Derived Sources so they don't appear in our
+        repository.
+
+        * ANGLE.xcodeproj/project.pbxproj:
+
 2021-12-08  Kyle Piddington  <kpiddington@apple.com>