Changeset 286841 in webkit

Timestamp:

Dec 10, 2021, 2:39:28 AM (5 years ago)

Author:

youenn@apple.com

Message:

REGRESSION (iOS 15): Safari loses Network access when establishing WebRTC session
​https://bugs.webkit.org/show_bug.cgi?id=233752
<rdar://problem/86196093>

Reviewed by Geoffrey Garen.

When we get an error from a UDP nw socket, we do not need to stop reading and close it.
We can just log the error and continue reading as the error might get fixed later on.

Not easily testable.

• NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-12-10  Youenn Fablet  <youenn@apple.com>
+
+        REGRESSION (iOS 15): Safari loses Network access when establishing WebRTC session
+        https://bugs.webkit.org/show_bug.cgi?id=233752
+        <rdar://problem/86196093>
+
+        Reviewed by Geoffrey Garen.
+
+        When we get an error from a UDP nw socket, we do not need to stop reading and close it.
+        We can just log the error and continue reading as the error might get fixed later on.
+
+        Not easily testable.
+
+        * NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm:
+
 2021-12-10  Kimmo Kinnunen  <kkinnunen@apple.com>
 

trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCUDPSocketCocoa.mm

@@ -289 +289 @@
         if (isComplete && context && nw_content_context_get_is_final(context))
             return;
-        if (error) {
-            RELEASE_LOG_ERROR(WebRTC, "NetworkRTCUDPSocketCocoaConnections failed processing UDP data with error %d", nw_error_get_error_code(error));
-            return;
-        }
+
+        RELEASE_LOG_ERROR_IF(!!error, WebRTC, "NetworkRTCUDPSocketCocoaConnections failed processing UDP data with error %d", nw_error_get_error_code(error));
         processUDPData(WTFMove(nwConnection), WTFMove(processData));
     }).get());