⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 286848 in webkit


Ignore:
Timestamp:
Dec 10, 2021, 6:27:04 AM (5 years ago)
Author:
Alan Bujtas
Message:

[LFC][IFC] Enable bidi handling for content with inline boxes
https://bugs.webkit.org/show_bug.cgi?id=234055

Reviewed by Antti Koivisto.

Source/WebCore:

  • layout/integration/LayoutIntegrationCoverage.cpp:

LayoutTests:

Progressions.

  • platform/mac/fast/borders/bidi-002-expected.txt:
  • platform/mac/fast/borders/bidi-012-expected.txt:
  • platform/mac/fast/borders/rtl-border-05-expected.txt:
Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r286840 r286848  
     12021-12-10  Alan Bujtas  <zalan@apple.com>
     2
     3        [LFC][IFC] Enable bidi handling for content with inline boxes
     4        https://bugs.webkit.org/show_bug.cgi?id=234055
     5
     6        Reviewed by Antti Koivisto.
     7
     8        Progressions.
     9
     10        * platform/mac/fast/borders/bidi-002-expected.txt:
     11        * platform/mac/fast/borders/bidi-012-expected.txt:
     12        * platform/mac/fast/borders/rtl-border-05-expected.txt:
     13
    1142021-12-10  Frederic Wang  <fwang@igalia.com>
    215
  • trunk/LayoutTests/platform/ios/fast/borders/bidi-012-expected.txt

    r286113 r286848  
    3434              text run at (55,25) width 29: "bbb "
    3535              text run at (83,25) width 26: "ccc "
    36               text run at (108,25) width 29 RTL: "ddd "
    37               text run at (136,25) width 30 RTL: "\x{202E} eee "
    38             RenderBR {BR} at (0,0) size 0x0
     36              text run at (108,25) width 25 RTL: "ddd"
     37              text run at (132,25) width 30 RTL: "\x{202E} eee "
     38              text run at (161,25) width 5: " "
     39            RenderBR {BR} at (165,25) size 1x19
    3940            RenderText {#text} at (11,73) size 20x19
    4041              text run at (11,73) width 20: "fff "
     
    4647            RenderText {#text} at (141,73) size 19x19
    4748              text run at (141,73) width 19: "jjj "
    48             RenderBR {BR} at (0,0) size 0x0
     49            RenderBR {BR} at (159,73) size 1x19
    4950            RenderText {#text} at (11,121) size 143x19
    5051              text run at (11,121) width 28: "kkk "
  • trunk/LayoutTests/platform/ios/fast/borders/rtl-border-05-expected.txt

    r179104 r286848  
    1818            RenderText {#text} at (122,39) size 46x19
    1919              text run at (122,39) width 46: " dgnjk "
    20             RenderImage {IMG} at (167,32) size 23x22 [border: (1px solid #0000FF)]
     20            RenderImage {IMG} at (122,32) size 23x22 [border: (1px solid #0000FF)]
    2121            RenderText {#text} at (0,71) size 41x19
    2222              text run at (0,71) width 41: "njkng "
  • trunk/LayoutTests/platform/mac/fast/borders/bidi-002-expected.txt

    r286113 r286848  
    11layer at (0,0) size 800x600
    22  RenderView at (0,0) size 800x600
    3 layer at (0,0) size 800x259
    4   RenderBlock {HTML} at (0,0) size 800x259
    5     RenderBody {BODY} at (8,16) size 784x227
     3layer at (0,0) size 800x260
     4  RenderBlock {HTML} at (0,0) size 800x260
     5    RenderBody {BODY} at (8,16) size 784x228
    66      RenderBlock {P} at (0,0) size 784x19
    77        RenderText {#text} at (0,1) size 521x18
     
    99          text run at (505,1) width 11 RTL: "\x{5D0}"
    1010          text run at (515,1) width 6: ")"
    11       RenderBlock {DIV} at (0,35) size 784x192
     11      RenderBlock {DIV} at (0,35) size 784x193
    1212        RenderBlock {P} at (16,0) size 294x88 [bgcolor=#FFFFCC] [border: (3px solid #000000)]
    1313          RenderInline {SPAN} at (0,0) size 118x38 [color=#000080] [border: (3px solid #000080) none (3px solid #000080)]
     
    2121          RenderText {#text} at (11,59) size 195x18
    2222            text run at (11,59) width 195: "JJJKKKLLLMMMNNNOOO"
    23         RenderBlock {P} at (16,104) size 294x88 [bgcolor=#FFFFCC] [border: (3px solid #000000)]
     23        RenderBlock {P} at (16,104) size 294x89 [bgcolor=#FFFFCC] [border: (3px solid #000000)]
    2424          RenderInline {SPAN} at (0,0) size 313x38 [color=#000080] [border: (3px solid #000080)]
    2525            RenderText {#text} at (30,26) size 275x18
    2626              text run at (30,26) width 99: "AAABBBCCC"
    2727              text run at (219,26) width 86 RTL: "\x{202E}IIIHHHGGG"
    28           RenderText {#text} at (128,26) size 209x51
     28          RenderText {#text} at (128,26) size 209x52
    2929            text run at (128,26) width 92 RTL: "FFFEEEDDD"
    30             text run at (11,59) width 83 RTL: "LLLKKKJJJ"
    31             text run at (93,59) width 113: "\x{202C}MMMNNNOOO"
     30            text run at (11,60) width 83 RTL: "LLLKKKJJJ"
     31            text run at (93,60) width 113: "\x{202C}MMMNNNOOO"
  • trunk/LayoutTests/platform/mac/fast/borders/bidi-012-expected.txt

    r286113 r286848  
    3434              text run at (55,26) width 29: "bbb "
    3535              text run at (83,26) width 26: "ccc "
    36               text run at (108,26) width 29 RTL: "ddd "
    37               text run at (136,26) width 30 RTL: "\x{202E} eee "
    38             RenderBR {BR} at (0,0) size 0x0
     36              text run at (108,26) width 25 RTL: "ddd"
     37              text run at (132,26) width 30 RTL: "\x{202E} eee "
     38              text run at (161,26) width 5: " "
     39            RenderBR {BR} at (165,26) size 1x18
    3940            RenderText {#text} at (11,74) size 20x18
    4041              text run at (11,74) width 20: "fff "
     
    4647            RenderText {#text} at (141,74) size 19x18
    4748              text run at (141,74) width 19: "jjj "
    48             RenderBR {BR} at (0,0) size 0x0
     49            RenderBR {BR} at (159,74) size 1x18
    4950            RenderText {#text} at (11,122) size 143x18
    5051              text run at (11,122) width 28: "kkk "
  • trunk/LayoutTests/platform/mac/fast/borders/rtl-border-05-expected.txt

    r177774 r286848  
    1515            text run at (73,39) width 5: " "
    1616            text run at (77,39) width 17: "gg"
    17           RenderInline {SPAN} at (0,0) size 183x53 [border: (1px solid #0000FF) (10px solid #FFA500) (1px solid #0000FF) (10px solid #008000)]
    18             RenderText {#text} at (138,39) size 45x18
    19               text run at (138,39) width 45: " dgnjk "
     17          RenderInline {SPAN} at (0,0) size 179x53 [border: (1px solid #0000FF) (10px solid #FFA500) (1px solid #0000FF) (10px solid #008000)]
     18            RenderText {#text} at (138,39) size 41x18
     19              text run at (138,39) width 41: " dgnjk"
    2020            RenderImage {IMG} at (0,64) size 22x22 [border: (1px solid #0000FF)]
    2121            RenderText {#text} at (22,72) size 41x18
  • trunk/Source/WebCore/ChangeLog

    r286846 r286848  
     12021-12-10  Alan Bujtas  <zalan@apple.com>
     2
     3        [LFC][IFC] Enable bidi handling for content with inline boxes
     4        https://bugs.webkit.org/show_bug.cgi?id=234055
     5
     6        Reviewed by Antti Koivisto.
     7
     8        * layout/integration/LayoutIntegrationCoverage.cpp:
     9
    1102021-12-10  Nikolas Zimmermann  <nzimmermann@igalia.com>
    211
  • trunk/Source/WebCore/layout/integration/LayoutIntegrationCoverage.cpp

    r286542 r286848  
    4747
    4848#define ALLOW_BIDI_CONTENT 1
    49 #define ALLOW_BIDI_CONTENT_WITH_INLINE_BOX 0
     49#define ALLOW_BIDI_CONTENT_WITH_INLINE_BOX 1
    5050
    5151#ifndef NDEBUG
Note: See TracChangeset for help on using the changeset viewer.