Changeset 286858 in webkit

Timestamp:

Dec 10, 2021, 10:17:47 AM (5 years ago)

Author:

Darin Adler

Message:

Use simpler idioms for std::less and std::greater possible in modern C++
​https://bugs.webkit.org/show_bug.cgi?id=234117

Reviewed by Anders Carlsson.

Source/WebCore:

• testing/InternalsMapLike.cpp:

(WebCore::InternalsMapLike::inspectValues const): Remove unneeded explicit
use of std:less, because this is what std::sort by default.

Source/WebKit:

• WebProcess/WebPage/MomentumEventDispatcher.cpp:

(WebKit::MomentumEventDispatcher::equalizeTailGaps): Removed unneeded
template arguments for std::greater, and removed explicit use of std::less,
since that's what std::sort does by default.

Source/WTF:

• wtf/ListDump.h:

(WTF::sortedListDump): Removed unnecessary template arguments to std::less.

Location:

trunk/Source

Files:

• WTF/ChangeLog (modified) (1 diff)
• WTF/wtf/ListDump.h (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/testing/InternalsMapLike.cpp (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2021-12-09  Darin Adler  <darin@apple.com>
+
+        Use simpler idioms for std::less and std::greater possible in modern C++
+        https://bugs.webkit.org/show_bug.cgi?id=234117
+
+        Reviewed by Anders Carlsson.
+
+        * wtf/ListDump.h:
+        (WTF::sortedListDump): Removed unnecessary template arguments to std::less.
+
 2021-12-10  Keith Miller  <keith_miller@apple.com>
 

trunk/Source/WTF/wtf/ListDump.h

@@ -122 +122 @@
 CString sortedListDump(const T& list, const char* comma = ", ")
 {
-    return sortedListDump(list, std::less<typename T::ValueType>(), comma);
+    return sortedListDump(list, std::less<>(), comma);
 }
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-12-09  Darin Adler  <darin@apple.com>
+
+        Use simpler idioms for std::less and std::greater possible in modern C++
+        https://bugs.webkit.org/show_bug.cgi?id=234117
+
+        Reviewed by Anders Carlsson.
+
+        * testing/InternalsMapLike.cpp:
+        (WebCore::InternalsMapLike::inspectValues const): Remove unneeded explicit
+        use of std:less, because this is what std::sort by default.
+
 2021-12-10  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebCore/testing/InternalsMapLike.cpp

@@ -69 +69 @@
 {
     auto result = copyToVector(m_values.values());
-    std::sort(result.begin(), result.end(), std::less<unsigned>());
+    std::sort(result.begin(), result.end());
     return result;
 }

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-12-09  Darin Adler  <darin@apple.com>
+
+        Use simpler idioms for std::less and std::greater possible in modern C++
+        https://bugs.webkit.org/show_bug.cgi?id=234117
+
+        Reviewed by Anders Carlsson.
+
+        * WebProcess/WebPage/MomentumEventDispatcher.cpp:
+        (WebKit::MomentumEventDispatcher::equalizeTailGaps): Removed unneeded
+        template arguments for std::greater, and removed explicit use of std::less,
+        since that's what std::sort does by default.
+
 2021-12-10  Per Arne Vollan  <pvollan@apple.com>
 

trunk/Source/WebKit/WebProcess/WebPage/MomentumEventDispatcher.cpp

@@ -438 +438 @@
 
         if (deltas[axis][0] > 0)
-            std::sort(deltas[axis].begin(), std::next(deltas[axis].begin(), firstZeroIndex[axis]), std::greater<float>());
+            std::sort(deltas[axis].begin(), std::next(deltas[axis].begin(), firstZeroIndex[axis]), std::greater());
         else
-            std::sort(deltas[axis].begin(), std::next(deltas[axis].begin(), firstZeroIndex[axis]), std::less<float>());
+            std::sort(deltas[axis].begin(), std::next(deltas[axis].begin(), firstZeroIndex[axis]));
     };