Changeset 286867 in webkit

Timestamp:

Dec 10, 2021, 11:55:25 AM (5 years ago)

Author:

Said Abou-Hallawa

Message:

[GPU Process] [Filters] Address review comments after r285597
​https://bugs.webkit.org/show_bug.cgi?id=234130

Reviewed by Darin Adler.

Most of the comments in ​https://bugs.webkit.org/show_bug.cgi?id=232457
have already been addressed. This patch covers the unaddressed ones.

• platform/graphics/filters/software/FEMorphologySoftwareApplier.cpp:

(WebCore::FEMorphologySoftwareApplier::apply const):
Remove wasteful ceilf() calls

• rendering/RenderLayerFilters.cpp:

(WebCore::RenderLayerFilters::buildFilter):
Capitalize the sentence in the FIXME comments.

• rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::applyResource):
Use 'auto' in a few places where the type can be deduced.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/filters/software/FEMorphologySoftwareApplier.cpp (modified) (1 diff)
• rendering/RenderLayerFilters.cpp (modified) (2 diffs)
• rendering/svg/RenderSVGResourceFilter.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-12-10  Said Abou-Hallawa  <said@apple.com>
+
+        [GPU Process] [Filters] Address review comments after r285597
+        https://bugs.webkit.org/show_bug.cgi?id=234130
+
+        Reviewed by Darin Adler.
+
+        Most of the comments in https://bugs.webkit.org/show_bug.cgi?id=232457
+        have already been addressed. This patch covers the unaddressed ones.
+
+        * platform/graphics/filters/software/FEMorphologySoftwareApplier.cpp:
+        (WebCore::FEMorphologySoftwareApplier::apply const):
+        Remove wasteful ceilf() calls
+
+        * rendering/RenderLayerFilters.cpp:
+        (WebCore::RenderLayerFilters::buildFilter):
+        Capitalize the sentence in the FIXME comments.
+
+        * rendering/svg/RenderSVGResourceFilter.cpp:
+        (WebCore::RenderSVGResourceFilter::applyResource):
+        Use 'auto' in a few places where the type can be deduced.
+
 2021-12-10  Gabriel Nava Marino  <gnavamarino@apple.com>
 

trunk/Source/WebCore/platform/graphics/filters/software/FEMorphologySoftwareApplier.cpp

@@ -183 +183 @@
     paintingData.srcPixelArray = &sourcePixelArray;
     paintingData.dstPixelArray = &destinationPixelArray;
-    paintingData.width = ceilf(effectDrawingRect.width());
-    paintingData.height = ceilf(effectDrawingRect.height());
-    paintingData.radiusX = ceilf(radiusX);
-    paintingData.radiusY = ceilf(radiusY);
+    paintingData.width = effectDrawingRect.width();
+    paintingData.height = effectDrawingRect.height();
+    paintingData.radiusX = radiusX;
+    paintingData.radiusY = radiusY;
 
     applyPlatform(paintingData);

trunk/Source/WebCore/rendering/RenderLayerFilters.cpp

@@ -121 +121 @@
     // If the filter fails to build, remove it from the layer. It will still attempt to
     // go through regular processing (e.g. compositing), but never apply anything.
-    // FIXME: this rebuilds the entire effects chain even if the filter style didn't change.
+    // FIXME: This rebuilds the entire effects chain even if the filter style didn't change.
     m_filter = CSSFilter::create(renderer, renderer.style().filter(), renderingMode, FloatSize { scaleFactor, scaleFactor }, Filter::ClipOperation::Unite, m_targetBoundingBox);
 }
@@ -159 +159 @@
     if (m_targetBoundingBox != targetBoundingBox) {
         m_targetBoundingBox = targetBoundingBox;
-        // FIXME: this rebuilds the entire effects chain even if the filter style didn't change.
+        // FIXME: This rebuilds the entire effects chain even if the filter style didn't change.
         m_filter = CSSFilter::create(renderer, renderer.style().filter(), m_filter->renderingMode(), m_filter->filterScale(), Filter::ClipOperation::Unite, m_targetBoundingBox);
     }

trunk/Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp

@@ -109 +109 @@
 
     // Determine absolute transformation matrix for filter. 
-    AffineTransform absoluteTransform = SVGRenderingContext::calculateTransformationToOutermostCoordinateSystem(renderer);
+    auto absoluteTransform = SVGRenderingContext::calculateTransformationToOutermostCoordinateSystem(renderer);
     if (!absoluteTransform.isInvertible()) {
         m_rendererFilterDataMap.remove(&renderer);
@@ -148 +148 @@
 
     // Change the coordinate transformation applied to the filtered element to reflect the resolution of the filter.
-    AffineTransform effectiveTransform = AffineTransform(filterScale.width(), 0, 0, filterScale.height(), 0, 0);
+    auto effectiveTransform = AffineTransform(filterScale.width(), 0, 0, filterScale.height(), 0, 0);
 
 #if ENABLE(DESTINATION_COLOR_SPACE_LINEAR_SRGB)
@@ -162 +162 @@
     }
     
-    GraphicsContext& sourceGraphicContext = sourceGraphic->context();
+    auto& sourceGraphicContext = sourceGraphic->context();
   
     filterData->sourceGraphicBuffer = WTFMove(sourceGraphic);