Changeset 286965 in webkit

Timestamp:

Dec 13, 2021, 12:12:23 PM (5 years ago)

Author:

youenn@apple.com

Message:

Fix buggy assert in CoreAudioSharedUnit::setupAudioUnit
​https://bugs.webkit.org/show_bug.cgi?id=234151

Reviewed by Eric Carlson.

Add the source as a client to the unit before reconfiguring the unit,
this makes the ASSERT(hasClients()) actually valid.
Manually tested.

• platform/mediastream/mac/CoreAudioCaptureSource.cpp:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mediastream/mac/CoreAudioCaptureSource.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-12-13  Youenn Fablet  <youenn@apple.com>
+
+        Fix buggy assert in CoreAudioSharedUnit::setupAudioUnit
+        https://bugs.webkit.org/show_bug.cgi?id=234151
+
+        Reviewed by Eric Carlson.
+
+        Add the source as a client to the unit before reconfiguring the unit,
+        this makes the ASSERT(hasClients()) actually valid.
+        Manually tested.
+
+        * platform/mediastream/mac/CoreAudioCaptureSource.cpp:
+
 2021-12-13  Nikolas Zimmermann  <nzimmermann@igalia.com>
 

trunk/Source/WebCore/platform/mediastream/mac/CoreAudioCaptureSource.cpp

@@ -763 +763 @@
     unit.setVolume(volume());
 
+    unit.addClient(*this);
+
     if (shouldReconfigure)
         unit.reconfigure();
-
-    unit.addClient(*this);
 }