Changeset 286966 in webkit

Timestamp:

Dec 13, 2021, 12:19:24 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

[ macOS and iOS ] editing/deleting/forward-delete-crash.html is timing out
​https://bugs.webkit.org/show_bug.cgi?id=230047

Patch by Rob Buis <​rbuis@igalia.com> on 2021-12-13
Reviewed by Wenson Hsieh.

Rewrite forward-delete-crash.html to avoid the timeouts on
macOS and iOS.

• editing/deleting/forward-delete-crash.html:
• platform/ipad/TestExpectations:
• platform/mac/TestExpectations:

Location:

trunk/LayoutTests

Files:

• ChangeLog (modified) (1 diff)
• editing/deleting/forward-delete-crash.html (modified) (2 diffs)
• platform/ipad/TestExpectations (modified) (1 diff)
• platform/mac/TestExpectations (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-12-13  Rob Buis  <rbuis@igalia.com>
+
+        [ macOS and iOS ] editing/deleting/forward-delete-crash.html is timing out
+        https://bugs.webkit.org/show_bug.cgi?id=230047
+
+        Reviewed by Wenson Hsieh.
+
+        Rewrite forward-delete-crash.html to avoid the timeouts on
+        macOS and iOS.
+
+        * editing/deleting/forward-delete-crash.html:
+        * platform/ipad/TestExpectations:
+        * platform/mac/TestExpectations:
+
 2021-12-13  Tim Nguyen  <ntim@apple.com>
 

trunk/LayoutTests/editing/deleting/forward-delete-crash.html

@@ -19 +19 @@
     img0.onerror = () => {
       document.execCommand('ForwardDelete');
-      setTimeout(function() { window.testRunner.notifyDone(); }, 0);
-      document.write("Test passes if it does not crash.");
     };
     let datalist0 = document.createElement('datalist');
@@ -40 +38 @@
       await document.fonts.load("80px Ahem");
     document.execCommand('Delete');
+    setTimeout(function() { document.write("Test passes if it does not crash."); window.testRunner.notifyDone(); }, 0);
   };
 </script>

trunk/LayoutTests/platform/ipad/TestExpectations

@@ -95 +95 @@
 webkit.org/b/203264 editing/pasteboard/smart-paste-paragraph-001.html [ Pass ]
 
-webkit.org/b/230047 editing/deleting/forward-delete-crash.html [ Pass Timeout ]
-
 webkit.org/b/231635 [ Release ] editing/selection/ios/scroll-to-reveal-selection-when-showing-software-keyboard.html [ Timeout ]
 

trunk/LayoutTests/platform/mac/TestExpectations

@@ -1085 +1085 @@
 editing/selection/triple-click-in-pre.html [ Failure ]
 
-webkit.org/b/230047 editing/deleting/forward-delete-crash.html [ Pass Timeout ]
-
 # rdar://problem/31243824
 webkit.org/b/158747 media/restore-from-page-cache.html [ Pass Failure Crash ]