Changeset 286970 in webkit

Timestamp:

Dec 13, 2021, 12:28:00 PM (5 years ago)

Author:

youenn@apple.com

Message:

FetchResponse::clone should use the relevant realm for the cloned response
​https://bugs.webkit.org/show_bug.cgi?id=234238

Reviewed by Alexey Shvayka.

Source/WebCore:

Reuse the relevant realm for cloning as per ​https://fetch.spec.whatwg.org/#dom-response-clone step 3.
If context is stopped, throw an InvalidStateError exception, like done in Chrome.

Test: http/wpt/fetch/clone-realm.html

• Modules/fetch/FetchResponse.cpp:
• Modules/fetch/FetchResponse.h:
• Modules/fetch/FetchResponse.idl:

LayoutTests:

• http/wpt/fetch/clone-realm-expected.txt: Added.
• http/wpt/fetch/clone-realm.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/wpt/fetch/clone-realm-expected.txt (added)
• LayoutTests/http/wpt/fetch/clone-realm.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/fetch/FetchResponse.cpp (modified) (1 diff)
• Source/WebCore/Modules/fetch/FetchResponse.h (modified) (1 diff)
• Source/WebCore/Modules/fetch/FetchResponse.idl (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-12-13  Youenn Fablet  <youenn@apple.com>
+
+        FetchResponse::clone should use the relevant realm for the cloned response
+        https://bugs.webkit.org/show_bug.cgi?id=234238
+
+        Reviewed by Alexey Shvayka.
+
+        * http/wpt/fetch/clone-realm-expected.txt: Added.
+        * http/wpt/fetch/clone-realm.html: Added.
+
 2021-12-13  Rob Buis  <rbuis@igalia.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-12-13  Youenn Fablet  <youenn@apple.com>
+
+        FetchResponse::clone should use the relevant realm for the cloned response
+        https://bugs.webkit.org/show_bug.cgi?id=234238
+
+        Reviewed by Alexey Shvayka.
+
+        Reuse the relevant realm for cloning as per https://fetch.spec.whatwg.org/#dom-response-clone step 3.
+        If context is stopped, throw an InvalidStateError exception, like done in Chrome.
+
+        Test: http/wpt/fetch/clone-realm.html
+
+        * Modules/fetch/FetchResponse.cpp:
+        * Modules/fetch/FetchResponse.h:
+        * Modules/fetch/FetchResponse.idl:
+
 2021-12-13  Alan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/Modules/fetch/FetchResponse.cpp

@@ -170 +170 @@
 }
 
-ExceptionOr<Ref<FetchResponse>> FetchResponse::clone(ScriptExecutionContext& context)
-{
+ExceptionOr<Ref<FetchResponse>> FetchResponse::clone()
+{
+    if (isContextStopped())
+        return Exception { InvalidStateError, "Context is stopped"_s };
+
     if (isDisturbedOrLocked())
         return Exception { TypeError, "Body is disturbed or locked"_s };
 
     ASSERT(scriptExecutionContext());
+    auto& context = *scriptExecutionContext();
 
     // If loading, let's create a stream so that data is teed on both clones.

trunk/Source/WebCore/Modules/fetch/FetchResponse.h

@@ -80 +80 @@
     const FetchHeaders& headers() const { return m_headers; }
     FetchHeaders& headers() { return m_headers; }
-    ExceptionOr<Ref<FetchResponse>> clone(ScriptExecutionContext&);
+    ExceptionOr<Ref<FetchResponse>> clone();
 
     void consumeBodyAsStream() final;

trunk/Source/WebCore/Modules/fetch/FetchResponse.idl

@@ -58 +58 @@
     [SameObject] readonly attribute FetchHeaders headers;
 
-    [CallWith=ScriptExecutionContext, NewObject] FetchResponse clone();
+    [NewObject] FetchResponse clone();
 };