⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 286976 in webkit


Ignore:
Timestamp:
Dec 13, 2021, 12:57:00 PM (5 years ago)
Author:
Alan Coon
Message:

Cherry-pick r286834. rdar://problem/86427901

Inspector "composite" events are all very short
​https://bugs.webkit.org/show_bug.cgi?id=234114
<rdar://86299391>

Reviewed by Tim Horton.

The kCATransactionPhasePreCommit callbacks fire after painting, but we want the composite
time to include painting so use kCATransactionPhasePreLayout.

  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm: (WebKit::RemoteLayerTreeDrawingArea::addCommitHandlers):
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm: (WebKit::TiledCoreAnimationDrawingArea::addCommitHandlers):

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@286834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:
branches/safari-612-branch/Source/WebKit
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • branches/safari-612-branch/Source/WebKit/ChangeLog

    r286974 r286976  
     12021-12-13  Alan Coon  <alancoon@apple.com>
     2
     3        Cherry-pick r286834. rdar://problem/86235740
     4
     5    Inspector "composite" events are all very short
     6    https://bugs.webkit.org/show_bug.cgi?id=234114
     7    <rdar://86299391>
     8   
     9    Reviewed by Tim Horton.
     10   
     11    The kCATransactionPhasePreCommit callbacks fire after painting, but we want the composite
     12    time to include painting so use kCATransactionPhasePreLayout.
     13   
     14    * WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
     15    (WebKit::RemoteLayerTreeDrawingArea::addCommitHandlers):
     16    * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
     17    (WebKit::TiledCoreAnimationDrawingArea::addCommitHandlers):
     18   
     19   
     20    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@286834 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     21
     22    2021-12-09  Simon Fraser  <simon.fraser@apple.com>
     23
     24            Inspector "composite" events are all very short
     25            https://bugs.webkit.org/show_bug.cgi?id=234114
     26            <rdar://86299391>
     27
     28            Reviewed by Tim Horton.
     29
     30            The kCATransactionPhasePreCommit callbacks fire after painting, but we want the composite
     31            time to include painting so use kCATransactionPhasePreLayout.
     32
     33            * WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
     34            (WebKit::RemoteLayerTreeDrawingArea::addCommitHandlers):
     35            * WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
     36            (WebKit::TiledCoreAnimationDrawingArea::addCommitHandlers):
     37
    1382021-12-13  Alan Coon  <alancoon@apple.com>
    239

  • branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm

    r279992 r286976  
    294294                corePage->inspectorController().willComposite(*coreFrame);
    295295        }
    296     } forPhase:kCATransactionPhasePreCommit];
     296    } forPhase:kCATransactionPhasePreLayout];
    297297   
    298298    [CATransaction addCommitHandler:[retainedPage = makeRefPtr(&m_webPage)] {

  • branches/safari-612-branch/Source/WebKit/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm

    r278253 r286976  
    427427                corePage->inspectorController().willComposite(*coreFrame);
    428428        }
    429     } forPhase:kCATransactionPhasePreCommit];
     429    } forPhase:kCATransactionPhasePreLayout];
    430430
    431431    [CATransaction addCommitHandler:[retainedPage = makeRefPtr(&m_webPage)] {
Note: See TracChangeset for help on using the changeset viewer.