Changeset 287025 in webkit

Timestamp:

Dec 14, 2021, 8:43:21 AM (5 years ago)

Author:

Angelos Oikonomopoulos

Message:

[JSC] Fix LocalJumpError in run-jsc-stress-tests
​https://bugs.webkit.org/show_bug.cgi?id=234295

Reviewed by Michael Catanzaro.

Ruby code cannot return from a Proc; use an if/else instead. This fixes
the LocalJumpError reported in ​https://bugs.webkit.org/show_bug.cgi?id=233926.

• Scripts/run-jsc-stress-tests:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/run-jsc-stress-tests (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2021-12-14  Angelos Oikonomopoulos  <angelos@igalia.com>
+
+        [JSC] Fix LocalJumpError in run-jsc-stress-tests
+        https://bugs.webkit.org/show_bug.cgi?id=234295
+
+        Reviewed by Michael Catanzaro.
+
+        Ruby code cannot return from a Proc; use an if/else instead. This fixes
+        the LocalJumpError reported in https://bugs.webkit.org/show_bug.cgi?id=233926.
+
+        * Scripts/run-jsc-stress-tests:
+
 2021-12-14  Jean-Yves Avenard  <jya@apple.com>
 

trunk/Tools/Scripts/run-jsc-stress-tests

@@ -1374 +1374 @@
         "no-llint",
         Proc.new { |*optionalTestSpecificOptions|
-            return nil unless $jitTests
-            {
-                :cfg => {
-                },
-                :testSpecificOptions => [
-                    "--useLLInt=false",
-                ] + optionalTestSpecificOptions
-            }
+            if $jitTests
+                {
+                    :cfg => {
+                    },
+                    :testSpecificOptions => [
+                        "--useLLInt=false",
+                    ] + optionalTestSpecificOptions
+                }
+            else
+                nil
+            end
         }
     ],
@@ -1389 +1392 @@
         Proc.new { |*optionalTestSpecificOptions|
             if $memoryLimited
-                return nil
+                nil
+            else
+                {
+                    :testSpecificOptions => optionalTestSpecificOptions
+                }
             end
-            {
-                :testSpecificOptions => optionalTestSpecificOptions
-            }
         }
     ]