Changeset 287046 in webkit

Timestamp:

Dec 14, 2021, 2:04:50 PM (5 years ago)

Author:

Patrick Angle

Message:

Web Inspector: After r286657, anonymous layers are providing an empty string for their grouping text
​https://bugs.webkit.org/show_bug.cgi?id=234012

Reviewed by Devin Rousso.

Covered by existing test: LayoutTests/inspector/css/getMatchedStylesForNodeLayerGrouping.html

For anonymous layers, we should not provide the text property to the frontend, as there is technically no
text, not an empty string, provided by the author. This is effectively a minor optimization, as the frontend
does correctly handle an empty string the same way it handles no string.

• inspector/InspectorStyleSheet.cpp:

(WebCore::buildArrayForGroupings):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/InspectorStyleSheet.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-12-14  Patrick Angle  <pangle@apple.com>
+
+        Web Inspector: After r286657, anonymous layers are providing an empty string for their grouping text
+        https://bugs.webkit.org/show_bug.cgi?id=234012
+
+        Reviewed by Devin Rousso.
+
+        Covered by existing test: LayoutTests/inspector/css/getMatchedStylesForNodeLayerGrouping.html
+
+        For anonymous layers, we should not provide the `text` property to the frontend, as there is technically no
+        text, not an empty string, provided by the author. This is effectively a minor optimization, as the frontend
+        does correctly handle an empty string the same way it handles no string.
+
+        * inspector/InspectorStyleSheet.cpp:
+        (WebCore::buildArrayForGroupings):
+
 2021-12-14  Alan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/inspector/InspectorStyleSheet.cpp

@@ -479 +479 @@
                 .setType(Protocol::CSS::Grouping::Type::LayerRule)
                 .release();
-            layerRulePayload->setText(downcast<CSSLayerBlockRule>(parentRule)->name());
+            auto layerName = downcast<CSSLayerBlockRule>(parentRule)->name();
+            if (!layerName.isEmpty())
+                layerRulePayload->setText(layerName);
             ruleGroupingPayloads.append(WTFMove(layerRulePayload));
         }