Changeset 287067 in webkit

Timestamp:

Dec 15, 2021, 1:36:17 AM (5 years ago)

Author:

youenn@apple.com

Message:

Make sure to start a realtime outgoing source in case it is taken to another sender
​https://bugs.webkit.org/show_bug.cgi?id=234296
<rdar://86276497>

Reviewed by Eric Carlson.

Source/WebCore:

We are asynchronously starting libwebrtc sources.
When a sender is created first and is assigned a source later, we take the source and assign it to the sender.
In that case, the source might not be started and we will not send any data.

Test: webrtc/addTransceiver-then-addTrack.html

• Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.cpp:

LayoutTests:

• webrtc/addTransceiver-then-addTrack-expected.txt: Added.
• webrtc/addTransceiver-then-addTrack.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/webrtc/addTransceiver-then-addTrack-expected.txt (added)
• LayoutTests/webrtc/addTransceiver-then-addTrack.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-12-15  Youenn Fablet  <youenn@apple.com>
+
+        Make sure to start a realtime outgoing source in case it is taken to another sender
+        https://bugs.webkit.org/show_bug.cgi?id=234296
+        <rdar://86276497>
+
+        Reviewed by Eric Carlson.
+
+        * webrtc/addTransceiver-then-addTrack-expected.txt: Added.
+        * webrtc/addTransceiver-then-addTrack.html: Added.
+
 2021-12-14  Joonghun Park  <jh718.park@samsung.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-12-15  Youenn Fablet  <youenn@apple.com>
+
+        Make sure to start a realtime outgoing source in case it is taken to another sender
+        https://bugs.webkit.org/show_bug.cgi?id=234296
+        <rdar://86276497>
+
+        Reviewed by Eric Carlson.
+
+        We are asynchronously starting libwebrtc sources.
+        When a sender is created first and is assigned a source later, we take the source and assign it to the sender.
+        In that case, the source might not be started and we will not send any data.
+
+        Test: webrtc/addTransceiver-then-addTrack.html
+
+        * Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.cpp:
+
 2021-12-15  Antoine Quint  <graouts@webkit.org>
 

trunk/Source/WebCore/Modules/mediastream/libwebrtc/LibWebRTCRtpSenderBackend.cpp

@@ -191 +191 @@
 {
     stopSource();
-    m_source = WTFMove(source);
+    m_source = std::exchange(source, nullptr);
     startSource();
 }
@@ -198 +198 @@
 {
     ASSERT(backend.hasSource());
-    stopSource();
-    m_source = WTFMove(backend.m_source);
-    backend.m_source = nullptr;
+    setSource(WTFMove(backend.m_source));
 }