Changeset 287073 in webkit

Timestamp:

Dec 15, 2021, 8:23:33 AM (5 years ago)

Author:

youenn@apple.com

Message:

RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit should only reset once
​https://bugs.webkit.org/show_bug.cgi?id=234340

Reviewed by Eric Carlson.

As seen in logs, there are cases where the unit is notified reset several times before it gets stopped and restarted.
This triggers resetting on WebProcess side several times which is unneeded.
Instead, we now only call reset once in a start/stop cycle of the audio unit.
Manually tested.

• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp:

(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit::notifyReset):
(WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit::start):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp (modified) (3 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-12-15  Youenn Fablet  <youenn@apple.com>
+
+        RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit should only reset once
+        https://bugs.webkit.org/show_bug.cgi?id=234340
+
+        Reviewed by Eric Carlson.
+
+        As seen in logs, there are cases where the unit is notified reset several times before it gets stopped and restarted.
+        This triggers resetting on WebProcess side several times which is unneeded.
+        Instead, we now only call reset once in a start/stop cycle of the audio unit.
+        Manually tested.
+
+        * GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp:
+        (WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit::notifyReset):
+        (WebKit::RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit::start):
+
 2021-12-15  Per Arne Vollan  <pvollan@apple.com>
 

trunk/Source/WebKit/GPUProcess/webrtc/RemoteAudioMediaStreamTrackRendererInternalUnitManager.cpp

@@ -89 +89 @@
     WebCore::CAAudioStreamDescription m_description;
     bool m_shouldRegisterAsSpeakerSamplesProducer { false };
+    bool m_canReset { true };
 };
 
@@ -179 +180 @@
 void RemoteAudioMediaStreamTrackRendererInternalUnitManager::Unit::notifyReset()
 {
+    if (!m_canReset)
+        return;
+
+    m_canReset = false;
     m_connection->send(Messages::GPUProcessConnection::ResetAudioMediaStreamTrackRendererInternalUnit { m_identifier }, 0);
 }
@@ -203 +208 @@
     m_generateOffset = 0;
     m_isPlaying = true;
+    m_canReset = true;
     m_ringBuffer = WebCore::CARingBuffer::adoptStorage(makeUniqueRef<ReadOnlySharedRingBufferStorage>(handle), description, numberOfFrames).moveToUniquePtr();
     m_renderSemaphore = WTFMove(semaphore);