Changeset 287388 in webkit

Timestamp:

Dec 23, 2021, 12:54:35 AM (5 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK][a11y] Test accessibility/svg-remote-element.html crashes with ATSPI
​https://bugs.webkit.org/show_bug.cgi?id=234563

Reviewed by Adrian Perez de Castro.

This is because the remote svg element wrappers can't be created because the svg image page hasn't the root
object set.

• accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::remoteSVGRootElement const): Set the root image wrapper element on the svg
image page.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• accessibility/AccessibilityRenderObject.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-12-23  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK][a11y] Test accessibility/svg-remote-element.html crashes with ATSPI
+        https://bugs.webkit.org/show_bug.cgi?id=234563
+
+        Reviewed by Adrian Perez de Castro.
+
+        This is because the remote svg element wrappers can't be created because the svg image page hasn't the root
+        object set.
+
+        * accessibility/AccessibilityRenderObject.cpp:
+        (WebCore::AccessibilityRenderObject::remoteSVGRootElement const): Set the root image wrapper element on the svg
+        image page.
+
 2021-12-23  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebCore/accessibility/AccessibilityRenderObject.cpp

@@ -3398 +3398 @@
     if (!is<AccessibilitySVGRoot>(rootSVGObject))
         return nullptr;
-    
+
+#if USE(ATSPI)
+    if (auto* page = document->page())
+        page->setAccessibilityRootObject(createIfNecessary == Create ? axObjectCache()->document().page()->accessibilityRootObject() : nullptr);
+#endif
+
     return downcast<AccessibilitySVGRoot>(rootSVGObject);
 }