⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 287620 in webkit


Ignore:
Timestamp:
Jan 5, 2022, 10:20:40 AM (5 years ago)
Author:
Russell Epstein
Message:

Cherry-pick r285710. rdar://problem/87125070

REGRESSION(r285624) Using revert keyword with a css variable hits assert
​https://bugs.webkit.org/show_bug.cgi?id=233031
rdar://85332271

Reviewed by Tim Horton.

Source/WebCore:

Test: fast/selectors/variable-revert-crash.html

  • style/StyleBuilderState.h:

Default initialization set the variable to a value that is not in the enumeration.

LayoutTests:

  • fast/selectors/variable-revert-crash-expected.txt: Added.
  • fast/selectors/variable-revert-crash.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@285710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:
branches/safari-612-branch
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed

  • branches/safari-612-branch/LayoutTests/ChangeLog

    r287369 r287620  
     12022-01-05  Russell Epstein  <repstein@apple.com>
     2
     3        Cherry-pick r285710. rdar://problem/87125070
     4
     5    REGRESSION(r285624) Using revert keyword with a css variable hits assert
     6    https://bugs.webkit.org/show_bug.cgi?id=233031
     7    rdar://85332271
     8   
     9    Reviewed by Tim Horton.
     10   
     11    Source/WebCore:
     12   
     13    Test: fast/selectors/variable-revert-crash.html
     14   
     15    * style/StyleBuilderState.h:
     16   
     17    Default initialization set the variable to a value that is not in the enumeration.
     18   
     19    LayoutTests:
     20   
     21    * fast/selectors/variable-revert-crash-expected.txt: Added.
     22    * fast/selectors/variable-revert-crash.html: Added.
     23   
     24   
     25    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     26
     27    2021-11-12  Antti Koivisto  <antti@apple.com>
     28
     29            REGRESSION(r285624) Using revert keyword with a css variable hits assert
     30            https://bugs.webkit.org/show_bug.cgi?id=233031
     31            rdar://85332271
     32
     33            Reviewed by Tim Horton.
     34
     35            * fast/selectors/variable-revert-crash-expected.txt: Added.
     36            * fast/selectors/variable-revert-crash.html: Added.
     37
    1382021-12-22  Alan Coon  <alancoon@apple.com>
    239

  • branches/safari-612-branch/Source/WebCore/ChangeLog

    r287618 r287620  
     12022-01-05  Russell Epstein  <repstein@apple.com>
     2
     3        Cherry-pick r285710. rdar://problem/87125070
     4
     5    REGRESSION(r285624) Using revert keyword with a css variable hits assert
     6    https://bugs.webkit.org/show_bug.cgi?id=233031
     7    rdar://85332271
     8   
     9    Reviewed by Tim Horton.
     10   
     11    Source/WebCore:
     12   
     13    Test: fast/selectors/variable-revert-crash.html
     14   
     15    * style/StyleBuilderState.h:
     16   
     17    Default initialization set the variable to a value that is not in the enumeration.
     18   
     19    LayoutTests:
     20   
     21    * fast/selectors/variable-revert-crash-expected.txt: Added.
     22    * fast/selectors/variable-revert-crash.html: Added.
     23   
     24   
     25    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@285710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     26
     27    2021-11-12  Antti Koivisto  <antti@apple.com>
     28
     29            REGRESSION(r285624) Using revert keyword with a css variable hits assert
     30            https://bugs.webkit.org/show_bug.cgi?id=233031
     31            rdar://85332271
     32
     33            Reviewed by Tim Horton.
     34
     35            Test: fast/selectors/variable-revert-crash.html
     36
     37            * style/StyleBuilderState.h:
     38
     39            Default initialization set the variable to a value that is not in the enumeration.
     40
    1412022-01-05  Russell Epstein  <repstein@apple.com>
    242

  • branches/safari-612-branch/Source/WebCore/style/StyleBuilderState.h

    r266683 r287620  
    130130    HashSet<String> m_inProgressPropertiesCustom;
    131131
    132     CascadeLevel m_cascadeLevel { };
     132    CascadeLevel m_cascadeLevel { CascadeLevel::Author };
    133133    ScopeOrdinal m_styleScopeOrdinal { };
    134134    SelectorChecker::LinkMatchMask m_linkMatch { };
Note: See TracChangeset for help on using the changeset viewer.