Changeset 287646 in webkit

Timestamp:

Jan 5, 2022, 12:08:29 PM (5 years ago)

Author:

youenn@apple.com

Message:

NetworkRTCProvider::attributedBundleIdentifierFromPageIdentifier should check for m_connection
​https://bugs.webkit.org/show_bug.cgi?id=234845
<rdar://82120356>

Reviewed by Eric Carlson.

NetworkRTCProvider may call attributedBundleIdentifierFromPageIdentifier in a background thread,
which will then hop to main thread to get its session.
NetworkRTCProvider might have been closed when getting to main thread so we need to check m_connection.

• NetworkProcess/webrtc/NetworkRTCProvider.cpp:

(WebKit::NetworkRTCProvider::attributedBundleIdentifierFromPageIdentifier):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/webrtc/NetworkRTCProvider.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2022-01-05  Youenn Fablet  <youenn@apple.com>
+
+        NetworkRTCProvider::attributedBundleIdentifierFromPageIdentifier should check for m_connection
+        https://bugs.webkit.org/show_bug.cgi?id=234845
+        <rdar://82120356>
+
+        Reviewed by Eric Carlson.
+
+        NetworkRTCProvider may call attributedBundleIdentifierFromPageIdentifier in a background thread,
+        which will then hop to main thread to get its session.
+        NetworkRTCProvider might have been closed when getting to main thread so we need to check m_connection. 
+
+        * NetworkProcess/webrtc/NetworkRTCProvider.cpp:
+        (WebKit::NetworkRTCProvider::attributedBundleIdentifierFromPageIdentifier):
+
 2022-01-05  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebKit/NetworkProcess/webrtc/NetworkRTCProvider.cpp

@@ -154 +154 @@
         String value;
         callOnMainRunLoopAndWait([&] {
-            auto* session = m_connection->networkSession();
+            auto* session = m_connection ? m_connection->networkSession() : nullptr;
             if (session)
                 value = session->attributedBundleIdentifierFromPageIdentifier(pageIdentifier).isolatedCopy();