Changeset 28774 in webkit


Ignore:
Timestamp:
Dec 16, 2007, 10:40:02 AM (17 years ago)
Author:
mitz@apple.com
Message:

WebCore:

Reviewed by Darin Adler.

Test: fast/overflow/scrollbar-position-update.html

  • platform/mac/PlatformScrollBarMac.mm: (WebCore::PlatformScrollbar::updateThumbProportion): Update the NSScroller's value for the new proportions.
  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::updateScrollInfoAfterLayout): Removed unnecessary repaint(). Scrollbars repaint themselves as needed.

LayoutTests:

Reviewed by Darin Adler.

  • fast/overflow/scrollbar-position-update.html: Added.
  • platform/mac-leopard/fast/overflow: Added.
  • platform/mac-leopard/fast/overflow/scrollbar-position-update-expected.checksum: Added.
  • platform/mac-leopard/fast/overflow/scrollbar-position-update-expected.png: Added.
  • platform/mac/fast/overflow/scrollbar-position-update-expected.txt: Added.
Location:
trunk
Files:
5 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r28763 r28774  
     12007-12-16  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        - test for http://bugs.webkit.org/show_bug.cgi?id=16426
     6          Divs with overflow:auto: scrollbars not correctly updated when contents change
     7
     8        * fast/overflow/scrollbar-position-update.html: Added.
     9        * platform/mac-leopard/fast/overflow: Added.
     10        * platform/mac-leopard/fast/overflow/scrollbar-position-update-expected.checksum: Added.
     11        * platform/mac-leopard/fast/overflow/scrollbar-position-update-expected.png: Added.
     12        * platform/mac/fast/overflow/scrollbar-position-update-expected.txt: Added.
     13
    1142007-12-15  Darin Adler  <darin@apple.com>
    215

  • trunk/WebCore/ChangeLog

    r28772 r28774  
     12007-12-16  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        - fix http://bugs.webkit.org/show_bug.cgi?id=16426
     6          Divs with overflow:auto: scrollbars not correctly updated when contents change
     7
     8        Test: fast/overflow/scrollbar-position-update.html
     9
     10        * platform/mac/PlatformScrollBarMac.mm:
     11        (WebCore::PlatformScrollbar::updateThumbProportion): Update the
     12        NSScroller's value for the new proportions.
     13        * rendering/RenderLayer.cpp:
     14        (WebCore::RenderLayer::updateScrollInfoAfterLayout): Removed unnecessary
     15        repaint(). Scrollbars repaint themselves as needed.
     16
    1172007-12-16  Alexey Proskuryakov  <ap@webkit.org>
    218

  • trunk/WebCore/platform/mac/PlatformScrollBarMac.mm

    r20507 r28774  
    137137void PlatformScrollbar::updateThumbProportion()
    138138{
    139     float val = (float)m_visibleSize/m_totalSize;
     139    float val = static_cast<float>(m_visibleSize) / m_totalSize;
    140140
    141141    BEGIN_BLOCK_OBJC_EXCEPTIONS;
    142142    WebCoreScrollBar *bar = (WebCoreScrollBar *)getView();
    143     if (!(val == [bar knobProportion] || val < 0.0))
    144         [bar setFloatValue: [bar floatValue] knobProportion: val];
     143    if (val != [bar knobProportion] && val >= 0)
     144        [bar setFloatValue:static_cast<float>(m_currentPos) / (m_totalSize - m_visibleSize) knobProportion:val];
    145145    END_BLOCK_OBJC_EXCEPTIONS;
    146146}

  • trunk/WebCore/rendering/RenderLayer.cpp

    r28523 r28774  
    12841284        m_vBar->setSteps(LINE_STEP, pageStep);
    12851285        m_vBar->setProportion(clientHeight, m_scrollHeight);
    1286         m_object->repaintRectangle(IntRect(m_object->borderLeft() + m_object->clientWidth(),
    1287                                    m_object->borderTop(), verticalScrollbarWidth(),
    1288                                    m_object->height() - m_object->borderTop() - m_object->borderBottom()));
    12891286    }
    12901287 
Note: See TracChangeset for help on using the changeset viewer.