⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 287743 in webkit


Ignore:
Timestamp:
Jan 7, 2022, 5:02:32 AM (5 years ago)
Author:
Nikolas Zimmermann
Message:

[LBSE] Rename RenderSVGRect -> LegacyRenderSVGRect
​https://bugs.webkit.org/show_bug.cgi?id=234878

Reviewed by Rob Buis.

Following the established procedure: rename RenderSVGRect -> LegacyRenderSVGRect.
In a follow-up patch RenderSVGRect will be reintroduced for LBSE, inheriting from
RenderSVGShape instead of LegacyRenderSVGShape.

Covered by existing tests, no change in behaviour.

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • rendering/svg/LegacyRenderSVGRect.cpp: Renamed from Source/WebCore/rendering/svg/RenderSVGRect.cpp.

(WebCore::LegacyRenderSVGRect::LegacyRenderSVGRect):
(WebCore::LegacyRenderSVGRect::rectElement const):
(WebCore::LegacyRenderSVGRect::updateShapeFromElement):
(WebCore::LegacyRenderSVGRect::fillShape const):
(WebCore::LegacyRenderSVGRect::strokeShape const):
(WebCore::LegacyRenderSVGRect::shapeDependentStrokeContains):
(WebCore::LegacyRenderSVGRect::shapeDependentFillContains const):
(WebCore::LegacyRenderSVGRect::isRenderingDisabled const):

  • rendering/svg/LegacyRenderSVGRect.h: Renamed from Source/WebCore/rendering/svg/RenderSVGRect.h.
  • svg/SVGRectElement.cpp:

(WebCore::SVGRectElement::createElementRenderer):

Location:
trunk/Source/WebCore
Files:
4 edited
2 moved

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r287742 r287743  
     12022-01-06  Nikolas Zimmermann  <nzimmermann@igalia.com>
     2
     3        [LBSE] Rename RenderSVGRect -> LegacyRenderSVGRect
     4        https://bugs.webkit.org/show_bug.cgi?id=234878
     5
     6        Reviewed by Rob Buis.
     7
     8        Following the established procedure: rename RenderSVGRect -> LegacyRenderSVGRect.
     9        In a follow-up patch RenderSVGRect will be reintroduced for LBSE, inheriting from
     10        RenderSVGShape instead of LegacyRenderSVGShape.
     11
     12        Covered by existing tests, no change in behaviour.
     13
     14        * Sources.txt:
     15        * WebCore.xcodeproj/project.pbxproj:
     16        * rendering/svg/LegacyRenderSVGRect.cpp: Renamed from Source/WebCore/rendering/svg/RenderSVGRect.cpp.
     17        (WebCore::LegacyRenderSVGRect::LegacyRenderSVGRect):
     18        (WebCore::LegacyRenderSVGRect::rectElement const):
     19        (WebCore::LegacyRenderSVGRect::updateShapeFromElement):
     20        (WebCore::LegacyRenderSVGRect::fillShape const):
     21        (WebCore::LegacyRenderSVGRect::strokeShape const):
     22        (WebCore::LegacyRenderSVGRect::shapeDependentStrokeContains):
     23        (WebCore::LegacyRenderSVGRect::shapeDependentFillContains const):
     24        (WebCore::LegacyRenderSVGRect::isRenderingDisabled const):
     25        * rendering/svg/LegacyRenderSVGRect.h: Renamed from Source/WebCore/rendering/svg/RenderSVGRect.h.
     26        * svg/SVGRectElement.cpp:
     27        (WebCore::SVGRectElement::createElementRenderer):
     28
    1292022-01-07  Martin Robinson  <mrobinson@webkit.org>
    230

  • trunk/Source/WebCore/Sources.txt

    r287693 r287743  
    24682468rendering/style/WillChangeData.cpp
    24692469rendering/svg/LegacyRenderSVGModelObject.cpp
     2470rendering/svg/LegacyRenderSVGRect.cpp
    24702471rendering/svg/LegacyRenderSVGRoot.cpp
    24712472rendering/svg/LegacyRenderSVGShape.cpp
    … …  
    24812482rendering/svg/RenderSVGModelObject.cpp
    24822483rendering/svg/RenderSVGPath.cpp
    2483 rendering/svg/RenderSVGRect.cpp
    24842484rendering/svg/RenderSVGResource.cpp
    24852485rendering/svg/RenderSVGResourceClipper.cpp

  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r287737 r287743  
    32713271                A104EC5E220A3E4E00CBF67A /* JSMockPaymentContactFields.h in Headers */ = {isa = PBXBuildFile; fileRef = A104EC5C220A3E4400CBF67A /* JSMockPaymentContactFields.h */; };
    32723272                A104F24414C71F7A009E2C23 /* CachedSVGDocument.h in Headers */ = {isa = PBXBuildFile; fileRef = A104F24214C71F7A009E2C23 /* CachedSVGDocument.h */; settings = {ATTRIBUTES = (Private, ); }; };
    3273                 A10BB5851484E3A700B2E87A /* RenderSVGRect.h in Headers */ = {isa = PBXBuildFile; fileRef = A10BB5831484E3A700B2E87A /* RenderSVGRect.h */; };
     3273                A10BB5851484E3A700B2E87A /* LegacyRenderSVGRect.h in Headers */ = {isa = PBXBuildFile; fileRef = A10BB5831484E3A700B2E87A /* LegacyRenderSVGRect.h */; };
    32743274                A10BB58B1484E3B300B2E87A /* LegacyRenderSVGShape.h in Headers */ = {isa = PBXBuildFile; fileRef = A10BB5891484E3B300B2E87A /* LegacyRenderSVGShape.h */; };
    32753275                A10DBF4718F92317000D70C6 /* LegacyPreviewLoaderClient.h in Headers */ = {isa = PBXBuildFile; fileRef = A10DBF4618F92317000D70C6 /* LegacyPreviewLoaderClient.h */; settings = {ATTRIBUTES = (Private, ); }; };
    … …  
    1337513375                A104F24114C71F7A009E2C23 /* CachedSVGDocument.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = CachedSVGDocument.cpp; sourceTree = "<group>"; };
    1337613376                A104F24214C71F7A009E2C23 /* CachedSVGDocument.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = CachedSVGDocument.h; sourceTree = "<group>"; };
    13377                 A10BB5821484E3A700B2E87A /* RenderSVGRect.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = RenderSVGRect.cpp; sourceTree = "<group>"; };
    13378                 A10BB5831484E3A700B2E87A /* RenderSVGRect.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = RenderSVGRect.h; sourceTree = "<group>"; };
     13377                A10BB5821484E3A700B2E87A /* LegacyRenderSVGRect.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = LegacyRenderSVGRect.cpp; sourceTree = "<group>"; };
     13378                A10BB5831484E3A700B2E87A /* LegacyRenderSVGRect.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = LegacyRenderSVGRect.h; sourceTree = "<group>"; };
    1337913379                A10BB5881484E3B300B2E87A /* LegacyRenderSVGShape.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = LegacyRenderSVGShape.cpp; sourceTree = "<group>"; };
    1338013380                A10BB5891484E3B300B2E87A /* LegacyRenderSVGShape.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = LegacyRenderSVGShape.h; sourceTree = "<group>"; };
    … …  
    1890718907                                4367088B12D9CA4A00044234 /* LegacyRenderSVGModelObject.cpp */,
    1890818908                                4367088C12D9CA4A00044234 /* LegacyRenderSVGModelObject.h */,
     18909                                A10BB5821484E3A700B2E87A /* LegacyRenderSVGRect.cpp */,
     18910                                A10BB5831484E3A700B2E87A /* LegacyRenderSVGRect.h */,
    1890918911                                436708A512D9CA4B00044234 /* LegacyRenderSVGRoot.cpp */,
    1891018912                                436708A612D9CA4B00044234 /* LegacyRenderSVGRoot.h */,
    … …  
    1893718939                                ADDF1AD41257CD9A0003A759 /* RenderSVGPath.cpp */,
    1893818940                                ADDF1AD51257CD9A0003A759 /* RenderSVGPath.h */,
    18939                                 A10BB5821484E3A700B2E87A /* RenderSVGRect.cpp */,
    18940                                 A10BB5831484E3A700B2E87A /* RenderSVGRect.h */,
    1894118941                                4367088D12D9CA4A00044234 /* RenderSVGResource.cpp */,
    1894218942                                4367088E12D9CA4A00044234 /* RenderSVGResource.h */,
    … …  
    3591035910                                A10DBF4718F92317000D70C6 /* LegacyPreviewLoaderClient.h in Headers */,
    3591135911                                436708CB12D9CA4B00044234 /* LegacyRenderSVGModelObject.h in Headers */,
     35912                                A10BB5851484E3A700B2E87A /* LegacyRenderSVGRect.h in Headers */,
    3591235913                                436708E512D9CA4B00044234 /* LegacyRenderSVGRoot.h in Headers */,
    3591335914                                A10BB58B1484E3B300B2E87A /* LegacyRenderSVGShape.h in Headers */,
    … …  
    3672736728                                43670C9342D9BC4B00044234 /* RenderSVGModelObject.h in Headers */,
    3672836729                                ADDF1AD71257CD9A0003A759 /* RenderSVGPath.h in Headers */,
    36729                                 A10BB5851484E3A700B2E87A /* RenderSVGRect.h in Headers */,
    3673036730                                436708CD12D9CA4B00044234 /* RenderSVGResource.h in Headers */,
    3673136731                                436708CF12D9CA4B00044234 /* RenderSVGResourceClipper.h in Headers */,

  • trunk/Source/WebCore/rendering/svg/LegacyRenderSVGRect.cpp

    r287742 r287743  
    2727
    2828#include "config.h"
    29 #include "RenderSVGRect.h"
     29#include "LegacyRenderSVGRect.h"
    3030
    3131#include "LegacyRenderSVGShapeInlines.h"
    … …  
    3535namespace WebCore {
    3636
    37 WTF_MAKE_ISO_ALLOCATED_IMPL(RenderSVGRect);
     37WTF_MAKE_ISO_ALLOCATED_IMPL(LegacyRenderSVGRect);
    3838
    39 RenderSVGRect::RenderSVGRect(SVGRectElement& element, RenderStyle&& style)
     39LegacyRenderSVGRect::LegacyRenderSVGRect(SVGRectElement& element, RenderStyle&& style)
    4040    : LegacyRenderSVGShape(element, WTFMove(style))
    4141    , m_usePathFallback(false)
    … …  
    4343}
    4444
    45 RenderSVGRect::~RenderSVGRect() = default;
     45LegacyRenderSVGRect::~LegacyRenderSVGRect() = default;
    4646
    47 SVGRectElement& RenderSVGRect::rectElement() const
     47SVGRectElement& LegacyRenderSVGRect::rectElement() const
    4848{
    4949    return downcast<SVGRectElement>(LegacyRenderSVGShape::graphicsElement());
    5050}
    5151
    52 void RenderSVGRect::updateShapeFromElement()
     52void LegacyRenderSVGRect::updateShapeFromElement()
    5353{
    5454    // Before creating a new object we need to clear the cached bounding box
    … …  
    9898}
    9999
    100 void RenderSVGRect::fillShape(GraphicsContext& context) const
     100void LegacyRenderSVGRect::fillShape(GraphicsContext& context) const
    101101{
    102102    if (m_usePathFallback) {
    … …  
    121121}
    122122
    123 void RenderSVGRect::strokeShape(GraphicsContext& context) const
     123void LegacyRenderSVGRect::strokeShape(GraphicsContext& context) const
    124124{
    125125    if (!style().hasVisibleStroke())
    … …  
    134134}
    135135
    136 bool RenderSVGRect::shapeDependentStrokeContains(const FloatPoint& point, PointCoordinateSpace pointCoordinateSpace)
     136bool LegacyRenderSVGRect::shapeDependentStrokeContains(const FloatPoint& point, PointCoordinateSpace pointCoordinateSpace)
    137137{
    138138    // The optimized contains code below does not support non-smooth strokes so we need
    … …  
    147147}
    148148
    149 bool RenderSVGRect::shapeDependentFillContains(const FloatPoint& point, const WindRule fillRule) const
     149bool LegacyRenderSVGRect::shapeDependentFillContains(const FloatPoint& point, const WindRule fillRule) const
    150150{
    151151    if (m_usePathFallback)
    … …  
    154154}
    155155
    156 bool RenderSVGRect::isRenderingDisabled() const
     156bool LegacyRenderSVGRect::isRenderingDisabled() const
    157157{
    158158    // A width or height of zero disables rendering for the element, and results in an empty bounding box.

  • trunk/Source/WebCore/rendering/svg/LegacyRenderSVGRect.h

    r287742 r287743  
    3333namespace WebCore {
    3434
    35 class RenderSVGRect final : public LegacyRenderSVGShape {
    36     WTF_MAKE_ISO_ALLOCATED(RenderSVGRect);
     35class LegacyRenderSVGRect final : public LegacyRenderSVGShape {
     36    WTF_MAKE_ISO_ALLOCATED(LegacyRenderSVGRect);
    3737public:
    38     RenderSVGRect(SVGRectElement&, RenderStyle&&);
    39     virtual ~RenderSVGRect();
     38    LegacyRenderSVGRect(SVGRectElement&, RenderStyle&&);
     39    virtual ~LegacyRenderSVGRect();
    4040
    4141    SVGRectElement& rectElement() const;

  • trunk/Source/WebCore/svg/SVGRectElement.cpp

    r283851 r287743  
    2424#include "SVGRectElement.h"
    2525
    26 #include "RenderSVGRect.h"
     26#include "LegacyRenderSVGRect.h"
    2727#include "RenderSVGResource.h"
    2828#include "SVGElementInlines.h"
    … …  
    8989RenderPtr<RenderElement> SVGRectElement::createElementRenderer(RenderStyle&& style, const RenderTreePosition&)
    9090{
    91     return createRenderer<RenderSVGRect>(*this, WTFMove(style));
     91    return createRenderer<LegacyRenderSVGRect>(*this, WTFMove(style));
    9292}
    9393
Note: See TracChangeset for help on using the changeset viewer.