Changeset 287760 in webkit

Timestamp:

Jan 7, 2022, 10:44:50 AM (5 years ago)

Author:

youenn@apple.com

Message:

Allow storing form data responses in Cache Storage
​https://bugs.webkit.org/show_bug.cgi?id=234881

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt:

Source/WebCore:

Covered by rebased tests.

• Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::put):

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/Modules/cache/DOMCache.cpp (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2022-01-07  Youenn Fablet  <youenn@apple.com>
+
+        Allow storing form data responses in Cache Storage
+        https://bugs.webkit.org/show_bug.cgi?id=234881
+
+        Reviewed by Alex Christensen.
+
+        * web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt:
+
 2022-01-07  Martin Robinson  <mrobinson@webkit.org>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt

@@ -25 +25 @@
 PASS Cache.put should store Response.redirect() correctly
 PASS Cache.put called with simple Request and blob Response
-FAIL Cache.put called with simple Request and form data Response promise_test: Unhandled rejection with value: object "NotSupportedError: Not implemented"
+PASS Cache.put called with simple Request and form data Response
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-01-07  Youenn Fablet  <youenn@apple.com>
+
+        Allow storing form data responses in Cache Storage
+        https://bugs.webkit.org/show_bug.cgi?id=234881
+
+        Reviewed by Alex Christensen.
+
+        Covered by rebased tests.
+
+        * Modules/cache/DOMCache.cpp:
+        (WebCore::DOMCache::put):
+
 2022-01-07  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/Modules/cache/DOMCache.cpp

@@ -366 +366 @@
     }
 
-    if (response->isBlobFormData()) {
-        promise.reject(Exception { NotSupportedError, "Not implemented"_s });
-        return;
-    }
-
-    // FIXME: for efficiency, we should load blobs directly instead of going through the readableStream path.
-    if (response->isBlobBody()) {
+    // FIXME: for efficiency, we should load blobs/form data directly instead of going through the readableStream path.
+    if (response->isBlobBody() || response->isBlobFormData()) {
         auto streamOrException = response->readableStream(*scriptExecutionContext()->globalObject());
         if (UNLIKELY(streamOrException.hasException())) {