Changeset 287761 in webkit

Timestamp:

Jan 7, 2022, 10:46:00 AM (5 years ago)

Author:

graouts@webkit.org

Message:

Values in WebAnimation::instances should not be null-checked
​https://bugs.webkit.org/show_bug.cgi?id=234948

Reviewed by Darin Adler.

The HashSet<WebAnimation*> returned by WebAnimation::instances() cannnot hold nullptr
values so we should not have any check for a null value when iterating over its values.

• dom/Document.cpp:

(WebCore::Document::matchingAnimations):
(WebCore::Document::keyframesRuleDidChange):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Document.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-01-07  Antoine Quint  <graouts@webkit.org>
+
+        Values in WebAnimation::instances should not be null-checked
+        https://bugs.webkit.org/show_bug.cgi?id=234948
+
+        Reviewed by Darin Adler.
+
+        The HashSet<WebAnimation*> returned by WebAnimation::instances() cannnot hold nullptr
+        values so we should not have any check for a null value when iterating over its values.
+
+        * dom/Document.cpp:
+        (WebCore::Document::matchingAnimations):
+        (WebCore::Document::keyframesRuleDidChange):
+
 2022-01-07  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -8556 +8556 @@
     Vector<RefPtr<WebAnimation>> animations;
     for (auto* animation : WebAnimation::instances()) {
-        if (!animation || !animation->isRelevant() || !is<KeyframeEffect>(animation->effect()))
+        if (!animation->isRelevant() || !is<KeyframeEffect>(animation->effect()))
             continue;
 
@@ -8574 +8574 @@
 {
     for (auto* animation : WebAnimation::instances()) {
-        if (!is<CSSAnimation>(animation) || !animation->isRelevant())
+        if (!is<CSSAnimation>(*animation) || !animation->isRelevant())
             continue;