Changeset 287774 in webkit

Timestamp:

Jan 7, 2022, 11:48:43 AM (5 years ago)

Author:

mmaxfield@apple.com

Message:

ImageBuffer with floating point logicalSize() paints into a slightly truncated destination rect
​https://bugs.webkit.org/show_bug.cgi?id=225377

Reviewed by Tim Horton.

This is the rest of ​https://bugs.webkit.org/show_bug.cgi?id=232470.

This is also a follow-up of ​https://bugs.webkit.org/show_bug.cgi?id=232515.

No new tests; the behavior change is covered by
fast/backgrounds/hidpi-bitmap-background-origin-on-subpixel-position.html
since Tim Horton reverted the workaround for this bug that he landed in r276945.

• Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:

(WebKit::RemoteLayerBackingStore::drawInContext):

• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::createRemoteImageBuffer):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• Shared/RemoteLayerTree/RemoteLayerBackingStore.mm (modified) (1 diff)
• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2022-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        ImageBuffer with floating point logicalSize() paints into a slightly truncated destination rect
+        https://bugs.webkit.org/show_bug.cgi?id=225377
+
+        Reviewed by Tim Horton.
+
+        This is the rest of https://bugs.webkit.org/show_bug.cgi?id=232470.
+
+        This is also a follow-up of https://bugs.webkit.org/show_bug.cgi?id=232515.
+
+        No new tests; the behavior change is covered by
+        fast/backgrounds/hidpi-bitmap-background-origin-on-subpixel-position.html
+        since Tim Horton reverted the workaround for this bug that he landed in r276945.
+
+        * Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
+        (WebKit::RemoteLayerBackingStore::drawInContext):
+        * WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
+        (WebKit::RemoteRenderingBackendProxy::createRemoteImageBuffer):
+
 2022-01-07  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm

@@ -372 +372 @@
     if (!m_dirtyRegion.contains(layerBounds)) {
         ASSERT(m_backBuffer.imageBuffer);
-        context.drawImageBuffer(*m_backBuffer.imageBuffer, { {0, 0}, m_size }, { {0, 0}, m_size }, { WebCore::CompositeOperator::Copy });
+        context.drawImageBuffer(*m_backBuffer.imageBuffer, { 0, 0 }, { WebCore::CompositeOperator::Copy });
     }
 

trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp

@@ -129 +129 @@
 {
     auto logicalSize = imageBuffer.logicalSize();
-    if (logicalSize.width() > 1 || logicalSize.height() > 1) {
-        // FIXME: https://bugs.webkit.org/show_bug.cgi?id=225377 If we unconditionally use imageBuffer.logicalSize() here instead of imageBuffer.truncatedLogicalSize(),
-        // there may be a memory regression. See https://trac.webkit.org/changeset/287358/webkit
-        logicalSize = imageBuffer.truncatedLogicalSize();
-    }
     sendToStream(Messages::RemoteRenderingBackend::CreateImageBuffer(logicalSize, imageBuffer.renderingMode(), imageBuffer.resolutionScale(), imageBuffer.colorSpace(), imageBuffer.pixelFormat(), imageBuffer.renderingResourceIdentifier()));
 }