Changeset 287794 in webkit

Timestamp:

Jan 7, 2022, 3:47:41 PM (5 years ago)

Author:

Chris Lord

Message:

[GTK] REGRESSION: Kinetic scrolling via touch-screen behaves oddly
​https://bugs.webkit.org/show_bug.cgi?id=234958

Reviewed by Michael Catanzaro.

The swipe signal handler didn't take into account
Scrollbar::pixelsPerLineStep() and also incorrectly negated the
vertical velocity. Ideally, touch scrolling would use precise wheel
events, but as the rest of the code works correctly and scales by this
amount, make the one-line change that conforms with the previous code.

• UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseTouchSwipe):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/gtk/WebKitWebViewBase.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2022-01-07  Chris Lord  <clord@igalia.com>
+
+        [GTK] REGRESSION: Kinetic scrolling via touch-screen behaves oddly
+        https://bugs.webkit.org/show_bug.cgi?id=234958
+
+        Reviewed by Michael Catanzaro.
+
+        The swipe signal handler didn't take into account
+        Scrollbar::pixelsPerLineStep() and also incorrectly negated the
+        vertical velocity. Ideally, touch scrolling would use precise wheel
+        events, but as the rest of the code works correctly and scales by this
+        amount, make the one-line change that conforms with the previous code.
+
+        * UIProcess/API/gtk/WebKitWebViewBase.cpp:
+        (webkitWebViewBaseTouchSwipe):
+
 2022-01-07  Patrick Angle  <pangle@apple.com>
 

trunk/Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp

@@ -2002 +2002 @@
         }
 
-        webkitWebViewBaseSynthesizeWheelEvent(webViewBase, event, -velocityX, -velocityY, x, y, WheelEventPhase::NoPhase, WheelEventPhase::Began);
+        webkitWebViewBaseSynthesizeWheelEvent(webViewBase, event, -velocityX / Scrollbar::pixelsPerLineStep(), velocityY / Scrollbar::pixelsPerLineStep(), x, y, WheelEventPhase::NoPhase, WheelEventPhase::Began);
     }
 }