Changeset 287828 in webkit

Timestamp:

Jan 9, 2022, 1:38:56 PM (5 years ago)

Author:

graouts@webkit.org

Message:

Style::Resolver::keyframeRulesForName() signature should be improved
​https://bugs.webkit.org/show_bug.cgi?id=235021

Reviewed by Darin Adler.

Darin pointed out during the review for bug 235008 that the method itself
should be const, not its return value.

• style/StyleResolver.cpp:

(WebCore::Style::Resolver::keyframeRulesForName const):
(WebCore::Style::Resolver::keyframeRulesForName): Deleted.

• style/StyleResolver.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• style/StyleResolver.cpp (modified) (1 diff)
• style/StyleResolver.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-01-09  Antoine Quint  <graouts@webkit.org>
+
+        Style::Resolver::keyframeRulesForName() signature should be improved
+        https://bugs.webkit.org/show_bug.cgi?id=235021
+
+        Reviewed by Darin Adler.
+
+        Darin pointed out during the review for bug 235008 that the method itself
+        should be const, not its return value.
+
+        * style/StyleResolver.cpp:
+        (WebCore::Style::Resolver::keyframeRulesForName const):
+        (WebCore::Style::Resolver::keyframeRulesForName): Deleted.
+        * style/StyleResolver.h:
+
 2022-01-09  Antoine Quint  <graouts@webkit.org>
 

trunk/Source/WebCore/style/StyleResolver.cpp

@@ -308 +308 @@
 }
 
-const Vector<Ref<StyleRuleKeyframe>> Resolver::keyframeRulesForName(const AtomString& animationName)
+Vector<Ref<StyleRuleKeyframe>> Resolver::keyframeRulesForName(const AtomString& animationName) const
 {
     if (animationName.isEmpty())

trunk/Source/WebCore/style/StyleResolver.h

@@ -140 +140 @@
 
     void addKeyframeStyle(Ref<StyleRuleKeyframes>&&);
-    const Vector<Ref<StyleRuleKeyframe>> keyframeRulesForName(const AtomString&);
+    Vector<Ref<StyleRuleKeyframe>> keyframeRulesForName(const AtomString&) const;
 
     bool usesFirstLineRules() const { return m_ruleSets.features().usesFirstLineRules; }