Changeset 287847 in webkit

Timestamp:

Jan 10, 2022, 11:06:53 AM (5 years ago)

Author:

cathiechen

Message:

ASSERTION FAILED in RenderLayer::updateClipRects
​https://bugs.webkit.org/show_bug.cgi?id=234315

Reviewed by Simon Fraser.

Source/WebCore:

In clippingRootForPainting(), the dialog element uses the top layer as its clipping root layer.
When it caculates the clip rects, it caculates all its ancestors' clip rects and caches them
including the clipping root layer. However, if the ancestor is a transformed layer, it should be
treated as a root layer. When the transformed layer updates its clip rects, the root layer won't
match the one in cache. This patch stops the dialog descendant propagating its clipping root layer
to the ancestors' in cache.

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clipCrossesPaintingBoundary const):

LayoutTests:

• TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/TestExpectations (modified) (2 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderLayer.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2022-01-10  Cathie Chen  <cathiechen@igalia.com>
+
+        ASSERTION FAILED in RenderLayer::updateClipRects
+        https://bugs.webkit.org/show_bug.cgi?id=234315
+
+        Reviewed by Simon Fraser.
+
+        * TestExpectations:
+
 2022-01-10  Chris Dumez  <cdumez@apple.com>
 

trunk/LayoutTests/TestExpectations

@@ -3950 +3950 @@
 webkit.org/b/230079 [ Debug ] imported/w3c/web-platform-tests/css/css-transforms/transform-transformed-tr-contains-fixed-position.html [ Skip ]
 webkit.org/b/230079 [ Debug ] imported/w3c/web-platform-tests/css/css-transforms/transform-transformed-tr-percent-height-child.html [ Skip ]
+webkit.org/b/230079 [ Debug ] fast/layers/top-layer-ancestor-opacity-and-transform-crash.html [ Skip ]
 
 webkit.org/b/230080 [ Release ] imported/w3c/web-platform-tests/css/css-transforms/transform-transformed-tbody-contains-fixed-position.html [ ImageOnlyFailure ]
@@ -5190 +5191 @@
 imported/w3c/web-platform-tests/css/css-shadow-parts/interaction-with-nested-pseudo-class.html [ ImageOnlyFailure ]
 
-webkit.org/b/234315 [ Debug ] fast/layers/top-layer-ancestor-opacity-and-transform-crash.html [ Skip ]
-
 webkit.org/b/183994 imported/w3c/web-platform-tests/css/cssom/css-style-attr-decl-block.html [ Failure ]
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-01-10  Cathie Chen  <cathiechen@igalia.com>
+
+        ASSERTION FAILED in RenderLayer::updateClipRects
+        https://bugs.webkit.org/show_bug.cgi?id=234315
+
+        Reviewed by Simon Fraser.
+
+        In clippingRootForPainting(), the dialog element uses the top layer as its clipping root layer.
+        When it caculates the clip rects, it caculates all its ancestors' clip rects and caches them
+        including the clipping root layer. However, if the ancestor is a transformed layer, it should be
+        treated as a root layer. When the transformed layer updates its clip rects, the root layer won't
+        match the one in cache. This patch stops the dialog descendant propagating its clipping root layer
+        to the ancestors' in cache.
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::clipCrossesPaintingBoundary const):
+
 2022-01-10  Tim Nguyen  <ntim@apple.com>
 

trunk/Source/WebCore/rendering/RenderLayer.cpp

@@ -4458 +4458 @@
 bool RenderLayer::clipCrossesPaintingBoundary() const
 {
+    if (establishesTopLayer())
+        return true;
+
     return parent()->enclosingPaginationLayer(IncludeCompositedPaginatedLayers) != enclosingPaginationLayer(IncludeCompositedPaginatedLayers)
         || parent()->enclosingCompositingLayerForRepaint() != enclosingCompositingLayerForRepaint();