Changeset 287855 in webkit

Timestamp:

Jan 10, 2022, 1:54:06 PM (5 years ago)

Author:

eric.carlson@apple.com

Message:

hasBrokenEncryptedMediaAPISupportQuirk and needsPreloadAutoQuirk have overly
permissive domain allow lists
​https://bugs.webkit.org/show_bug.cgi?id=222130
<rdar://problem/74758560>

Reviewed by Jer Noble.

Fix quirk tests for subdomains of vimeo and hulu by using RegistrableDomain instead
of testing the url directly.

• page/Quirks.cpp:

(WebCore::Quirks::hasBrokenEncryptedMediaAPISupportQuirk const):
(WebCore::Quirks::needsPreloadAutoQuirk const):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/Quirks.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-01-10  Eric Carlson  <eric.carlson@apple.com>
+
+        hasBrokenEncryptedMediaAPISupportQuirk and needsPreloadAutoQuirk have overly
+        permissive domain allow lists
+        https://bugs.webkit.org/show_bug.cgi?id=222130
+        <rdar://problem/74758560>
+
+        Reviewed by Jer Noble.
+
+        Fix quirk tests for subdomains of vimeo and hulu by using RegistrableDomain instead
+        of testing the url directly.
+
+        * page/Quirks.cpp:
+        (WebCore::Quirks::hasBrokenEncryptedMediaAPISupportQuirk const):
+        (WebCore::Quirks::needsPreloadAutoQuirk const):
+
 2022-01-10  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/page/Quirks.cpp

@@ -180 +180 @@
         return m_hasBrokenEncryptedMediaAPISupportQuirk.value();
 
-    auto domain = m_document->securityOrigin().domain().convertToASCIILowercase();
-
-    m_hasBrokenEncryptedMediaAPISupportQuirk = domain == "starz.com"
-        || domain.endsWith(".starz.com")
-        || domain == "youtube.com"
-        || domain.endsWith(".youtube.com")
-        || domain == "hulu.com"
-        || domain.endsWith("hulu.com");
+    auto domain = RegistrableDomain(m_document->url()).string();
+    m_hasBrokenEncryptedMediaAPISupportQuirk = domain == "starz.com"_s || domain == "youtube.com"_s || domain == "hulu.com"_s;
 
     return m_hasBrokenEncryptedMediaAPISupportQuirk.value();
@@ -823 +817 @@
         return m_needsPreloadAutoQuirk.value();
 
-    auto domain = m_document->securityOrigin().domain().convertToASCIILowercase();
-
-    m_needsPreloadAutoQuirk = domain == "vimeo.com" || domain.endsWith("vimeo.com");
+    auto domain = RegistrableDomain(m_document->url()).string();
+    m_needsPreloadAutoQuirk = domain == "vimeo"_s;
 
     return m_needsPreloadAutoQuirk.value();