Changeset 287872 in webkit

Timestamp:

Jan 11, 2022, 12:53:55 AM (5 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK][a11y] WTR: do not immediately process main thread events while waiting for ax thread task
​https://bugs.webkit.org/show_bug.cgi?id=234950

Reviewed by Adrian Perez de Castro.

Source/WebCore:

Run a layout before creating the isolated tree to ensure we get an updated tree after ignored is computed.

• accessibility/isolatedtree/AXIsolatedTree.cpp:

(WebCore::AXIsolatedTree::create):

Tools:

We want to process the main thread events while waiting for ax thread to avoid blocking in case the ax thread
needs to get any value from the main thread. This might have side effects causing things to happen earlier than
expected. This patch only process main thread events after 125 milliseconds waiting for the ax thread, because
that probably means the ax thread is waiting for the main thread. This made most of the test to pass in isolated
tree mode with ATSPI.

• WebKitTestRunner/InjectedBundle/atspi/AccessibilityControllerAtspi.cpp:

(WTR::AccessibilityController::executeOnAXThreadAndWait):

Location:

trunk

Files:

• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityControllerAtspi.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK][a11y] WTR: do not immediately process main thread events while waiting for ax thread task
+        https://bugs.webkit.org/show_bug.cgi?id=234950
+
+        Reviewed by Adrian Perez de Castro.
+
+        Run a layout before creating the isolated tree to ensure we get an updated tree after ignored is computed.
+
+        * accessibility/isolatedtree/AXIsolatedTree.cpp:
+        (WebCore::AXIsolatedTree::create):
+
 2022-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp

@@ -98 +98 @@
     auto tree = adoptRef(*new AXIsolatedTree(axObjectCache));
 
+    auto& document = axObjectCache->document();
+    if (!document.view()->layoutContext().isInRenderTreeLayout() && !document.inRenderTreeUpdate() && !document.inStyleRecalc())
+        document.updateLayoutIgnorePendingStylesheets();
+
     // Generate the nodes of the tree and set its root and focused objects.
     // For this, we need the root and focused objects of the AXObject tree.

trunk/Tools/ChangeLog

@@ +1 @@
+2022-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK][a11y] WTR: do not immediately process main thread events while waiting for ax thread task
+        https://bugs.webkit.org/show_bug.cgi?id=234950
+
+        Reviewed by Adrian Perez de Castro.
+
+        We want to process the main thread events while waiting for ax thread to avoid blocking in case the ax thread
+        needs to get any value from the main thread. This might have side effects causing things to happen earlier than
+        expected. This patch only process main thread events after 125 milliseconds waiting for the ax thread, because
+        that probably means the ax thread is waiting for the main thread. This made most of the test to pass in isolated
+        tree mode with ATSPI.
+
+        * WebKitTestRunner/InjectedBundle/atspi/AccessibilityControllerAtspi.cpp:
+        (WTR::AccessibilityController::executeOnAXThreadAndWait):
+
 2022-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityControllerAtspi.cpp

@@ -153 +153 @@
         done.store(true);
     });
-    while (!done.load())
-        g_main_context_iteration(nullptr, FALSE);
+    auto now = MonotonicTime::now();
+    while (!done.load()) {
+        if (MonotonicTime::now() - now >= 125_ms)
+            g_main_context_iteration(nullptr, FALSE);
+    }
 }