⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 287874 in webkit


Ignore:
Timestamp:
Jan 11, 2022, 5:22:12 AM (5 years ago)
Author:
Diego Pino Garcia
Message:

REGRESSION (Lazy tree creation): css3/calc/transitions-dependent.html is frequently failing
​https://bugs.webkit.org/show_bug.cgi?id=126142
<rdar://problem/15725243>

Reviewed by Alexey Proskuryakov.

This test is no longer flaky, it has been consistently failing with fixed values. Update
'innerTransition' expected values to match actual values.

The test code was modernized to make it pass in other browsers since getPropertyCSSValue()
is deprecated and no longer supported by Chrome or Firefox).

  • TestExpectations:
  • css3/calc/transitions-dependent-expected.txt:
  • css3/calc/transitions-dependent.html:
  • platform/gtk/TestExpectations:
Location:
trunk/LayoutTests
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r287867 r287874  
     12022-01-11  Diego Pino Garcia  <dpino@igalia.com>
     2
     3        REGRESSION (Lazy tree creation): css3/calc/transitions-dependent.html is frequently failing
     4        https://bugs.webkit.org/show_bug.cgi?id=126142
     5        <rdar://problem/15725243>
     6
     7        Reviewed by Alexey Proskuryakov.
     8
     9        This test is no longer flaky, it has been consistently failing with fixed values.  Update
     10        'innerTransition' expected values to match actual values.
     11
     12        The test code was modernized to make it pass in other browsers since getPropertyCSSValue()
     13        is deprecated and no longer supported by Chrome or Firefox).
     14
     15        * TestExpectations:
     16        * css3/calc/transitions-dependent-expected.txt:
     17        * css3/calc/transitions-dependent.html:
     18        * platform/gtk/TestExpectations:
     19
    1202022-01-10  Alan Bujtas  <zalan@apple.com>
    221

  • trunk/LayoutTests/TestExpectations

    r287847 r287874  
    12281228
    12291229webkit.org/b/53990 fast/forms/search-event-delay.html [ Pass Failure ]
    1230 
    1231 webkit.org/b/126142 css3/calc/transitions-dependent.html [ Pass Failure ]
    12321230
    12331231webkit.org/b/124932 media/video-size.html [ Pass Failure ]

  • trunk/LayoutTests/css3/calc/transitions-dependent-expected.txt

    r121351 r287874  
    55PASS - "width" property for "inner" element at 0.75s was: 210
    66PASS - "width" property for "inner" element at 1s was: 260
    7 PASS - "width" property for "innerTransition" element at 0s was: 20
    8 PASS - "width" property for "innerTransition" element at 0.25s was: 70
    9 PASS - "width" property for "innerTransition" element at 0.5s was: 165
    10 PASS - "width" property for "innerTransition" element at 0.75s was: 305
     7PASS - "width" property for "innerTransition" element at 0s was: 60
     8PASS - "width" property for "innerTransition" element at 0.25s was: 167.5
     9PASS - "width" property for "innerTransition" element at 0.5s was: 275
     10PASS - "width" property for "innerTransition" element at 0.75s was: 382.5
    1111PASS - "width" property for "innerTransition" element at 1s was: 490
    1212

  • trunk/LayoutTests/css3/calc/transitions-dependent.html

    r236541 r287874  
    11<!DOCTYPE html>
    2 <style>
    3 .outerBlock {
    4     border: 1px solid black;
    5     -webkit-transition: all 1s linear;
    6     -moz-transition: all 1s linear;
    7 }
     2<html>
     3<head>
     4   <meta charset="UTF-8">
     5   <title></title>
    86
    9 .innerBlock {   
    10     background-color: green;
    11     height: 100px;
    12     -webkit-transition: all 1s linear;
    13     -moz-transition: all 1s linear;   
    14 }
     7  <style>
     8  .outerBlock {
     9     border: 1px solid black;
     10     -webkit-transition: all 1s linear;
     11     -moz-transition: all 1s linear;
     12  }
    1513
    16 #outer {
    17     width: 100px;
    18 }
     14  .innerBlock {
     15     background-color: green;
     16     height: 100px;
     17     -webkit-transition: all 1s linear;
     18     -moz-transition: all 1s linear;
     19  }
    1920
    20 #outer.go {
    21     width: 500px;
    22 }
     21  #outer {
     22     width: 100px;
     23  }
    2324
    24 #inner {
    25     width: calc(50% + 10px);
    26 }
     25  #outer.go {
     26     width: 500px;
     27  }
    2728
    28 #innerTransition {
    29     width: calc(10% + 10px);
    30 }
     29  #inner {
     30     width: calc(50% + 10px);
     31  }
    3132
    32 #innerTransition.go {
    33     width: calc(100% - 10px);
    34 }
     33  #innerTransition {
     34     width: calc(10% + 10px);
     35  }
    3536
    36 </style>
     37  #innerTransition.go {
     38     width: calc(100% - 10px);
     39  }
     40  </style>
     41</head>
    3742
    38 This tests that calc() expressions depending on transitioning elements behave correctly.
    39 <div class="outerBlock" id="outer">
    40     <div class="innerBlock" id="inner"></div>
    41     <div class="innerBlock" id="innerTransition"></div>
    42 </div>
    43 <div id="result"></div>
     43<body>
     44  This tests that calc() expressions depending on transitioning elements behave correctly.
     45  <div class="outerBlock" id="outer">
     46     <div class="innerBlock" id="inner"></div>
     47     <div class="innerBlock" id="innerTransition"></div>
     48  </div>
     49  <div id="result"></div>
     50</body>
    4451
    4552<script src="../../transitions/resources/transition-test-helpers.js"></script>
    … …  
    4754
    4855if (window.testRunner)
    49     window.testRunner.dumpAsText();
     56    testRunner.dumpAsText();
    5057
    5158const transitioningElements = ["outer", "innerTransition"];
    … …  
    5966    [1.00, "inner", 'width', 260, "outer"],
    6067
    61     [0.00, "innerTransition", 'width', 20, "outer"],
    62     [0.25, "innerTransition", 'width', 70, "outer"],
    63     [0.50, "innerTransition", 'width', 165, "outer"],
    64     [0.75, "innerTransition", 'width', 305, "outer"],
     68    [0.00, "innerTransition", 'width', 60, "outer"],
     69    [0.25, "innerTransition", 'width', 167.5, "outer"],
     70    [0.50, "innerTransition", 'width', 275, "outer"],
     71    [0.75, "innerTransition", 'width', 382.5, "outer"],
    6572    [1.00, "innerTransition", 'width', 490, "outer"],
    6673];
    6774
    68 function runTest(expected)
     75function getPropertyCSSValue(elementId, property)
    6976{
    70     for (var i = 0; i < expected.length; ++i) {
    71         var time = expected[i][0];
    72         var elementId = expected[i][1];
    73         var property = expected[i][2];
    74         var expectedValue = expected[i][3];
    75         var dependsOn = expected[i][4];
    76         pauseTransitionAtTimeOnElement(property, time, document.getElementById(dependsOn));
    77         pauseTransitionAtTimeOnElement(property, time, document.getElementById(elementId));
    78         var actual = window.getComputedStyle(document.getElementById(elementId)).getPropertyCSSValue(property).getFloatValue(CSSPrimitiveValue.CSS_NUMBER);
    79         var result = document.getElementById("result");
     77    let element = document.getElementById(elementId);
     78    let style = window.getComputedStyle(element, null);
     79    return style.getPropertyValue(property);
     80}
     81
     82function runTest(expected)
     83{
     84    let result = document.getElementById("result");
     85    for (let i = 0; i < expected.length; i++) {
     86        let [time, elementId, property, expectedValue, dependsOn] = expected[i];
     87        let elem = (i < 5) ? dependsOn : elementId;
     88        pauseTransitionAtTimeOnElement(property, time, document.getElementById(elem));
     89        let actual = Number.parseFloat(getPropertyCSSValue(elementId, property));
    8090        if (actual == expectedValue)
    8191            result.innerHTML += 'PASS - "' + property + '" property for "' + elementId +'" element at ' + time + 's was: ' + actual + '<br/>';
    … …  
    92102}
    93103
    94 for (var i = 0; i < transitioningElements.length; i++) {
    95     var element = document.getElementById(transitioningElements[i]);
     104for (let each of transitioningElements) {
     105    let element = document.getElementById(each);
    96106    element.className += " go";
    97107}
    98108
    99109window.addEventListener("load", loadListener, false);
    100 window.testRunner.waitUntilDone();
     110if (window.testRunner)
     111    testRunner.waitUntilDone();
    101112
    102113</script>
     114
     115</html>

  • trunk/LayoutTests/platform/gtk/TestExpectations

    r287846 r287874  
    10531053
    10541054webkit.org/b/127742 fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html [ Failure ]
    1055 
    1056 # Tests showing flakiness in the bot
    1057 webkit.org/b/132182 css3/calc/transitions-dependent.html [ Failure ]
    10581055
    10591056webkit.org/b/132385 compositing/repaint/repaint-on-layer-grouping-change.html [ Failure Pass ]
Note: See TracChangeset for help on using the changeset viewer.