Changeset 287875 in webkit

Timestamp:

Jan 11, 2022, 5:45:53 AM (5 years ago)

Author:

Martin Robinson

Message:

Some css-transforms tests assert in debug
​https://bugs.webkit.org/show_bug.cgi?id=230079
<rdar://problem/83179970>

Reviewed by Simon Fraser.

Source/WebCore:

No new tests. This is covered by existing WPT tests. This change fixes
five assertions and one test completely. In addition, it leads to progressions,
but not complete fixes, in the four remaining tests.

Table elements, which can be transformed, were not properly forming containing blocks
for fixed and absolutely positioned elements.

• rendering/RenderElement.h:

(WebCore::RenderElement::canContainFixedPositionObjects const): Return true even when
we have a transformed element that is not a block.
(WebCore::RenderElement::canContainAbsolutelyPositionedObjects const): Ditto.
(WebCore::RenderElement::isTransformable const): Added this helper which returns whether
not SVG elements are transformable. Eventually this should be extended to handle SVG
elements as well.

LayoutTests:

• TestExpectations: Update expectations to note new passes.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderElement.h (modified) (4 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2022-01-11  Martin Robinson  <mrobinson@webkit.org>
+
+        Some css-transforms tests assert in debug
+        https://bugs.webkit.org/show_bug.cgi?id=230079
+        <rdar://problem/83179970>
+
+        Reviewed by Simon Fraser.
+
+        * TestExpectations: Update expectations to note new passes.
+
 2022-01-11  Diego Pino Garcia  <dpino@igalia.com>
 

trunk/LayoutTests/TestExpectations

@@ -3943 +3943 @@
 imported/w3c/web-platform-tests/css/css-transforms/backface-visibility-001.ref.html [ Skip ]
 
-webkit.org/b/230079 [ Debug ] imported/w3c/web-platform-tests/css/css-transforms/transform-transformed-tbody-contains-fixed-position.html [ Skip ]
-webkit.org/b/230079 [ Debug ] imported/w3c/web-platform-tests/css/css-transforms/transform-transformed-tfoot-contains-fixed-position.html [ Skip ]
-webkit.org/b/230079 [ Debug ] imported/w3c/web-platform-tests/css/css-transforms/transform-transformed-thead-contains-fixed-position.html [ Skip ]
-webkit.org/b/230079 [ Debug ] imported/w3c/web-platform-tests/css/css-transforms/transform-transformed-tr-contains-fixed-position.html [ Skip ]
-webkit.org/b/230079 [ Debug ] imported/w3c/web-platform-tests/css/css-transforms/transform-transformed-tr-percent-height-child.html [ Skip ]
-webkit.org/b/230079 [ Debug ] fast/layers/top-layer-ancestor-opacity-and-transform-crash.html [ Skip ]
-
-webkit.org/b/230080 [ Release ] imported/w3c/web-platform-tests/css/css-transforms/transform-transformed-tbody-contains-fixed-position.html [ ImageOnlyFailure ]
-webkit.org/b/230080 [ Release ] imported/w3c/web-platform-tests/css/css-transforms/transform-transformed-tfoot-contains-fixed-position.html [ ImageOnlyFailure ]
-webkit.org/b/230080 [ Release ] imported/w3c/web-platform-tests/css/css-transforms/transform-transformed-thead-contains-fixed-position.html [ ImageOnlyFailure ]
-webkit.org/b/230080 [ Release ] imported/w3c/web-platform-tests/css/css-transforms/transform-transformed-tr-contains-fixed-position.html [ ImageOnlyFailure ]
-webkit.org/b/230080 [ Release ] imported/w3c/web-platform-tests/css/css-transforms/transform-transformed-tr-percent-height-child.html [ ImageOnlyFailure ]
+webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-transformed-tbody-contains-fixed-position.html [ ImageOnlyFailure ]
+webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-transformed-tfoot-contains-fixed-position.html [ ImageOnlyFailure ]
+webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-transformed-thead-contains-fixed-position.html [ ImageOnlyFailure ]
+webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/transform-transformed-tr-percent-height-child.html [ ImageOnlyFailure ]
+
+webkit.org/b/235063 [ Debug ] fast/layers/top-layer-ancestor-opacity-and-transform-crash.html [ Skip ]
 
 webkit.org/b/230080 imported/w3c/web-platform-tests/css/css-transforms/3d-rendering-context-and-abspos.html [ ImageOnlyFailure ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-01-11  Martin Robinson  <mrobinson@webkit.org>
+
+        Some css-transforms tests assert in debug
+        https://bugs.webkit.org/show_bug.cgi?id=230079
+        <rdar://problem/83179970>
+
+        Reviewed by Simon Fraser.
+
+        No new tests. This is covered by existing WPT tests. This change fixes
+        five assertions and one test completely. In addition, it leads to progressions,
+        but not complete fixes, in the four remaining tests.
+
+        Table elements, which can be transformed, were not properly forming containing blocks
+        for fixed and absolutely positioned elements.
+
+        * rendering/RenderElement.h:
+        (WebCore::RenderElement::canContainFixedPositionObjects const): Return true even when
+        we have a transformed element that is not a block.
+        (WebCore::RenderElement::canContainAbsolutelyPositionedObjects const): Ditto.
+        (WebCore::RenderElement::isTransformable const): Added this helper which returns whether
+        not SVG elements are transformable. Eventually this should be extended to handle SVG
+        elements as well.
+
 2022-01-11  Nikolas Zimmermann  <nzimmermann@igalia.com>
 

trunk/Source/WebCore/rendering/RenderElement.h

@@ -85 +85 @@
     bool canContainFixedPositionObjects() const;
     bool canContainAbsolutelyPositionedObjects() const;
+    bool canEstablishContainingBlockWithTransform() const;
 
     Color selectionColor(CSSPropertyID) const;
@@ -456 +457 @@
 {
     return isRenderView()
-        || (isRenderBlock() && hasTransform())
+        || (canEstablishContainingBlockWithTransform() && hasTransform())
         // FIXME: will-change should create containing blocks on inline boxes (bug 225035)
         || (isRenderBlock() && style().willChange() && style().willChange()->createsContainingBlockForOutOfFlowPositioned())
@@ -467 +468 @@
 {
     return style().position() != PositionType::Static
-        || (isRenderBlock() && hasTransformRelatedProperty())
+        || (canEstablishContainingBlockWithTransform() && hasTransformRelatedProperty())
         // FIXME: will-change should create containing blocks on inline boxes (bug 225035)
         || (isRenderBlock() && style().willChange() && style().willChange()->createsContainingBlockForAbsolutelyPositioned())
@@ -476 +477 @@
 }
 
+inline bool RenderElement::canEstablishContainingBlockWithTransform() const
+{
+    return isRenderBlock() || (isTablePart() && !isRenderTableCol());
+}
+
 inline bool RenderElement::createsGroupForStyle(const RenderStyle& style)
 {