Changeset 287879 in webkit

Timestamp:

Jan 11, 2022, 7:41:14 AM (5 years ago)

Author:

weinig@apple.com

Message:

Remove AppleTV specific disabling of conic gradients, its not necessary
​https://bugs.webkit.org/show_bug.cgi?id=235041

Reviewed by Darin Adler.

Source/WebCore:

There doesn't seem to be any reason to disable conic gradients on AppleTV. We do still
need to disable it on windows, but rather than hard coding this in WebCore, use a new
HAVE macro to conditionalize the code.

• platform/graphics/cg/GradientCG.cpp:

(WebCore::Gradient::paint):

• platform/graphics/cg/GradientRendererCG.cpp:

(WebCore::GradientRendererCG::drawConicGradient):

Source/WTF:

Add HAVE_CORE_GRAPHICS_CONIC_GRADIENTS macro and use it to control ENABLE_CSS_CONIC_GRADIENTS.

• wtf/PlatformEnableCocoa.h:
• wtf/PlatformHave.h:

Location:

trunk/Source

Files:

• WTF/ChangeLog (modified) (1 diff)
• WTF/wtf/PlatformEnableCocoa.h (modified) (1 diff)
• WTF/wtf/PlatformHave.h (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/graphics/cg/GradientCG.cpp (modified) (1 diff)
• WebCore/platform/graphics/cg/GradientRendererCG.cpp (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2022-01-11  Sam Weinig  <weinig@apple.com>
+
+        Remove AppleTV specific disabling of conic gradients, its not necessary
+        https://bugs.webkit.org/show_bug.cgi?id=235041
+
+        Reviewed by Darin Adler.
+
+        Add HAVE_CORE_GRAPHICS_CONIC_GRADIENTS macro and use it to control ENABLE_CSS_CONIC_GRADIENTS.
+
+        * wtf/PlatformEnableCocoa.h:
+        * wtf/PlatformHave.h:
+
 2022-01-10  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WTF/wtf/PlatformEnableCocoa.h

@@ -180 +180 @@
 #endif
 
-// FIXME: Seems likely this can be enabled for tvOS.
-#if !defined(ENABLE_CSS_CONIC_GRADIENTS) && !PLATFORM(APPLETV)
+#if !defined(ENABLE_CSS_CONIC_GRADIENTS)
 #define ENABLE_CSS_CONIC_GRADIENTS 1
 #endif

trunk/Source/WTF/wtf/PlatformHave.h

@@ -918 +918 @@
 #define HAVE_CORE_GRAPHICS_ROMMRGB_COLOR_SPACE 1
 #define HAVE_CORE_GRAPHICS_XYZ_COLOR_SPACE 1
+#define HAVE_CORE_GRAPHICS_CONIC_GRADIENTS 1
 #endif
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-01-11  Sam Weinig  <weinig@apple.com>
+
+        Remove AppleTV specific disabling of conic gradients, its not necessary
+        https://bugs.webkit.org/show_bug.cgi?id=235041
+
+        Reviewed by Darin Adler.
+
+        There doesn't seem to be any reason to disable conic gradients on AppleTV. We do still
+        need to disable it on windows, but rather than hard coding this in WebCore, use a new
+        HAVE macro to conditionalize the code.
+
+        * platform/graphics/cg/GradientCG.cpp:
+        (WebCore::Gradient::paint):
+        * platform/graphics/cg/GradientRendererCG.cpp:
+        (WebCore::GradientRendererCG::drawConicGradient):
+
 2022-01-11  Tim Nguyen  <ntim@apple.com>
 

trunk/Source/WebCore/platform/graphics/cg/GradientCG.cpp

@@ -161 +161 @@
         },
         [&] (const ConicData& data) {
-// FIXME: Seems like this should be HAVE(CG_CONTEXT_DRAW_CONIC_GRADIENT).
-// FIXME: Can we change tvOS to be like the other Cocoa platforms?
-#if PLATFORM(COCOA) && !PLATFORM(APPLETV)
+#if HAVE(CORE_GRAPHICS_CONIC_GRADIENTS)
             CGContextSaveGState(platformContext);
             CGContextTranslateCTM(platformContext, data.point0.x(), data.point0.y());

trunk/Source/WebCore/platform/graphics/cg/GradientRendererCG.cpp

@@ -685 +685 @@
 void GradientRendererCG::drawConicGradient(CGContextRef platformContext, CGPoint center, CGFloat angle)
 {
-// FIXME: Seems like this should be HAVE(CG_CONTEXT_DRAW_CONIC_GRADIENT).
-// FIXME: Can we change tvOS to be like the other Cocoa platforms?
-#if PLATFORM(COCOA) && !PLATFORM(APPLETV)
+#if HAVE(CORE_GRAPHICS_CONIC_GRADIENTS)
     WTF::switchOn(m_strategy,
         [&] (Gradient& gradient) {