Changeset 287981 in webkit

Timestamp:

Jan 13, 2022, 10:21:34 AM (5 years ago)

Author:

Alan Bujtas

Message:

REGRESSION (r278561): Right clicking a link selects the full line with unrelated text
​https://bugs.webkit.org/show_bug.cgi?id=235172
<rdar://84069534>

Reviewed by Dean Jackson.

Source/WebCore:

r278561 slightly change highlightStateForTextBox's behavior which now (correctly) returns HighlightState::None when the
RenderText content is not part of the current selection. Prior to r278561, it returned the RenderText's original selection state
which in this case was HighlightState::End.

<div><span>A<br>B<span style="position: absolute"></span></span>C</div>

In this specific case when we select the outer <span>, we end up with the following selection states for the generated line boxes:

(B) -> "Inside"
(C) -> "None"

while previously (C) came back as "End" (note that the absolute positioned element does not generate line boxes).

Now as Line::selectionState traverses through the line boxes, it comes across an unexpected "Inside -> None" transition at the selection end boundary (B -> C)
which incorrectly leaves the line state in "Inside" and we paint the selection all the way to the end of the block.

Test: fast/editing/selection-with-absolute-positioned-empty-content.html

• layout/integration/InlineIteratorLine.cpp:

(WebCore::InlineIterator::Line::selectionState const):

LayoutTests:

• fast/editing/selection-with-absolute-positioned-empty-content-expected.txt: Added.
• fast/editing/selection-with-absolute-positioned-empty-content.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/editing/selection-with-absolute-positioned-empty-content-expected.txt (added)
• LayoutTests/editing/selection-with-absolute-positioned-empty-content.html (added)
• LayoutTests/platform/ios/TestExpectations (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/layout/integration/InlineIteratorLine.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2022-01-13  Alan Bujtas  <zalan@apple.com>
+
+        REGRESSION (r278561): Right clicking a link selects the full line with unrelated text
+        https://bugs.webkit.org/show_bug.cgi?id=235172
+        <rdar://84069534>
+
+        Reviewed by Dean Jackson.
+
+        * fast/editing/selection-with-absolute-positioned-empty-content-expected.txt: Added.
+        * fast/editing/selection-with-absolute-positioned-empty-content.html: Added.
+
 2022-01-10  Sergio Villar Senin  <svillar@igalia.com>
 

trunk/LayoutTests/platform/ios/TestExpectations

@@ -422 +422 @@
 editing/selection/selecting-content-by-overshooting-the-deprecated-flex-container.html [ Skip ]
 editing/selection/selecting-content-by-overshooting-the-grid-container.html [ Skip ]
+editing/selection-with-absolute-positioned-empty-content.html [ Skip ]
 editing/spelling/context-menu-suggestions-multiword-selection.html [ Skip ]
 editing/spelling/context-menu-suggestions-subword-selection.html [ Skip ]

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-01-13  Alan Bujtas  <zalan@apple.com>
+
+        REGRESSION (r278561): Right clicking a link selects the full line with unrelated text
+        https://bugs.webkit.org/show_bug.cgi?id=235172
+        <rdar://84069534>
+
+        Reviewed by Dean Jackson.
+
+        r278561 slightly change highlightStateForTextBox's behavior which now (correctly) returns HighlightState::None when the
+        RenderText content is not part of the current selection. Prior to r278561, it returned the RenderText's original selection state
+        which in this case was HighlightState::End.
+
+        <div><span>A<br>B<span style="position: absolute"></span></span>C</div>
+
+        In this specific case when we select the outer <span>, we end up with the following selection states for the generated line boxes:
+          (B) -> "Inside"
+          (C) -> "None"
+        while previously (C) came back as "End" (note that the absolute positioned element does not generate line boxes).
+
+        Now as Line::selectionState traverses through the line boxes, it comes across an unexpected "Inside -> None" transition at the selection end boundary (B -> C)
+        which incorrectly leaves the line state in "Inside" and we paint the selection all the way to the end of the block.
+
+        Test: fast/editing/selection-with-absolute-positioned-empty-content.html
+
+        * layout/integration/InlineIteratorLine.cpp:
+        (WebCore::InlineIterator::Line::selectionState const):
+
 2022-01-13  Peng Liu  <peng.liu6@apple.com>
 

trunk/Source/WebCore/layout/integration/InlineIteratorLine.cpp

@@ -191 +191 @@
             // We are past the end of the selection.
             state = RenderObject::HighlightState::Both;
-        }
+        } else if (boxState == RenderObject::HighlightState::None && state == RenderObject::HighlightState::Inside)
+            state = RenderObject::HighlightState::End;
+
         if (state == RenderObject::HighlightState::Both)
             break;