Changeset 287985 in webkit

Timestamp:

Jan 13, 2022, 12:10:09 PM (5 years ago)

Author:

Ross Kirsling

Message:

PlayStation MiniBrowser should accept a command-line URL argument
​https://bugs.webkit.org/show_bug.cgi?id=235193

Reviewed by Don Olmstead.

Windows MiniBrowser can be launched from the command line with a URL argument for the initial page to load;
this patch allows PlayStation MiniBrowser to do similarly.

• MiniBrowser/playstation/MainWindow.cpp:

(MainWindow::MainWindow):

• MiniBrowser/playstation/MainWindow.h:
• MiniBrowser/playstation/main.cpp:

(main):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• MiniBrowser/playstation/MainWindow.cpp (modified) (2 diffs)
• MiniBrowser/playstation/MainWindow.h (modified) (1 diff)
• MiniBrowser/playstation/main.cpp (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2022-01-13  Ross Kirsling  <ross.kirsling@sony.com>
+
+        PlayStation MiniBrowser should accept a command-line URL argument
+        https://bugs.webkit.org/show_bug.cgi?id=235193
+
+        Reviewed by Don Olmstead.
+
+        Windows MiniBrowser can be launched from the command line with a URL argument for the initial page to load;
+        this patch allows PlayStation MiniBrowser to do similarly.
+
+        * MiniBrowser/playstation/MainWindow.cpp:
+        (MainWindow::MainWindow):
+        * MiniBrowser/playstation/MainWindow.h:
+        * MiniBrowser/playstation/main.cpp:
+        (main):
+
 2022-01-13  Patrick Angle  <pangle@apple.com>
 

trunk/Tools/MiniBrowser/playstation/MainWindow.cpp

@@ -42 +42 @@
 using namespace toolkitten;
 
-MainWindow::MainWindow()
+MainWindow::MainWindow(const char* requestedURL)
 {
     IntSize size = Application::singleton().windowSize();
@@ -107 +107 @@
 
     createNewWebView(nullptr);
-    activeWebView()->loadURL("https://webkit.org");
+    activeWebView()->loadURL(requestedURL ? requestedURL : "https://webkit.org");
 }
 

trunk/Tools/MiniBrowser/playstation/MainWindow.h

@@ -36 +36 @@
 class MainWindow final : public toolkitten::Widget {
 public:
-    MainWindow();
+    MainWindow(const char*);
 
     WebViewWindow* activeWebView();

trunk/Tools/MiniBrowser/playstation/main.cpp

@@ -77 +77 @@
 };
 
-int main(int, char *[])
+int main(int argc, char *argv[])
 {
     WKRunLoopInitializeMain();
@@ -85 +85 @@
     app.init(&applicationClient);
 
-    auto mainWindow = std::make_unique<MainWindow>();
+    auto mainWindow = std::make_unique<MainWindow>(argc > 1 ? argv[1] : nullptr);
     mainWindow->setFocused();
     app.setRootWidget(move(mainWindow));