Changeset 287986 in webkit

Timestamp:

Jan 13, 2022, 12:22:50 PM (5 years ago)

Author:

timothy_horton@apple.com

Message:

Fix a few Objective-C object leaks due to early returns in init
​https://bugs.webkit.org/show_bug.cgi?id=235162
<rdar://problem/87489048>

Reviewed by Wenson Hsieh.

Source/JavaScriptCore:

• API/JSValue.mm:

(-[JSValue initWithValue:inContext:]):

Source/WebCore:

• platform/ios/WebAVPlayerController.mm:

(-[WebAVPlayerController init]):

Source/WebKit:

• UIProcess/ios/WKHoverPlatter.mm:

(-[WKHoverPlatter initWithView:delegate:]):

Source/WebKitLegacy/mac:

• Storage/WebDatabaseQuotaManager.mm:

(WebCore::if):

Location:

trunk/Source

Files:

• JavaScriptCore/API/JSValue.mm (modified) (1 diff)
• JavaScriptCore/ChangeLog (modified) (1 diff)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/ios/WebAVPlayerController.mm (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/UIProcess/ios/WKHoverPlatter.mm (modified) (1 diff)
• WebKitLegacy/mac/ChangeLog (modified) (1 diff)
• WebKitLegacy/mac/Storage/WebDatabaseQuotaManager.mm (modified) (1 diff)

trunk/Source/JavaScriptCore/API/JSValue.mm

@@ -1109 +1109 @@
 - (JSValue *)initWithValue:(JSValueRef)value inContext:(JSContext *)context
 {
-    if (!value || !context)
+    if (!value || !context) {
+        [self release];
         return nil;
+    }
 
     self = [super init];

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2022-01-13  Tim Horton  <timothy_horton@apple.com>
+
+        Fix a few Objective-C object leaks due to early returns in `init`
+        https://bugs.webkit.org/show_bug.cgi?id=235162
+        <rdar://problem/87489048>
+
+        Reviewed by Wenson Hsieh.
+
+        * API/JSValue.mm:
+        (-[JSValue initWithValue:inContext:]):
+
 2022-01-12  Mark Lam  <mark.lam@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-01-13  Tim Horton  <timothy_horton@apple.com>
+
+        Fix a few Objective-C object leaks due to early returns in `init`
+        https://bugs.webkit.org/show_bug.cgi?id=235162
+        <rdar://problem/87489048>
+
+        Reviewed by Wenson Hsieh.
+
+        * platform/ios/WebAVPlayerController.mm:
+        (-[WebAVPlayerController init]):
+
 2022-01-13  Alejandro G. Castro  <alex@igalia.com>
 

trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm

@@ -67 +67 @@
 - (instancetype)init
 {
-    if (!getAVPlayerControllerClass())
+    if (!getAVPlayerControllerClass()) {
+        [self release];
         return nil;
+    }
 
     if (!(self = [super init]))

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2022-01-13  Tim Horton  <timothy_horton@apple.com>
+
+        Fix a few Objective-C object leaks due to early returns in `init`
+        https://bugs.webkit.org/show_bug.cgi?id=235162
+        <rdar://problem/87489048>
+
+        Reviewed by Wenson Hsieh.
+
+        * UIProcess/ios/WKHoverPlatter.mm:
+        (-[WKHoverPlatter initWithView:delegate:]):
+
 2022-01-13  Patrick Angle  <pangle@apple.com>
 

trunk/Source/WebKit/UIProcess/ios/WKHoverPlatter.mm

@@ -94 +94 @@
 {
     auto parameters = WKHoverPlatterDomain.rootSettings;
-    if (!parameters.platterEnabledForMouse && !parameters.platterEnabledForHover)
+    if (!parameters.platterEnabledForMouse && !parameters.platterEnabledForHover) {
+        [self release];
         return nil;
+    }
 
     self = [super init];

trunk/Source/WebKitLegacy/mac/ChangeLog

@@ +1 @@
+2022-01-13  Tim Horton  <timothy_horton@apple.com>
+
+        Fix a few Objective-C object leaks due to early returns in `init`
+        https://bugs.webkit.org/show_bug.cgi?id=235162
+        <rdar://problem/87489048>
+
+        Reviewed by Wenson Hsieh.
+
+        * Storage/WebDatabaseQuotaManager.mm:
+        (WebCore::if):
+
 2022-01-12  Matt Woodrow  <mattwoodrow@apple.com>
 

trunk/Source/WebKitLegacy/mac/Storage/WebDatabaseQuotaManager.mm

@@ -36 +36 @@
 - (id)initWithOrigin:(WebSecurityOrigin *)origin
 {
-    if (!origin)
+    if (!origin) {
+        [self release];
         return nil;
+    }
 
     self = [super init];