Changeset 288097 in webkit

Timestamp:

Jan 17, 2022, 10:30:16 AM (5 years ago)

Author:

ddkilzer@apple.com

Message:

Follow-up: REGRESSION (r286603): Leak of three NSMutableDictionary objects each time rx::DisplayMtl::getMetalDeviceMatchingAttribute() is called
<​https://webkit.org/b/235278>
<rdar://problem/87653812>

Unreviewed follow-up fix from Bug 235281, Comment #5.

• src/libANGLE/renderer/metal/DisplayMtl.mm:

(rx::DisplayMtl::getMetalDeviceMatchingAttribute):

• Remove unneeded calls to .get().

Location:

trunk/Source/ThirdParty/ANGLE

Files:

• ChangeLog (modified) (1 diff)
• src/libANGLE/renderer/metal/DisplayMtl.mm (modified) (1 diff)

trunk/Source/ThirdParty/ANGLE/ChangeLog

@@ +1 @@
+2022-01-17  David Kilzer  <ddkilzer@apple.com>
+
+        Follow-up: REGRESSION (r286603): Leak of three NSMutableDictionary objects each time rx::DisplayMtl::getMetalDeviceMatchingAttribute() is called
+        <https://webkit.org/b/235278>
+        <rdar://problem/87653812>
+
+        Unreviewed follow-up fix from Bug 235281, Comment #5.
+
+        * src/libANGLE/renderer/metal/DisplayMtl.mm:
+        (rx::DisplayMtl::getMetalDeviceMatchingAttribute):
+        - Remove unneeded calls to .get().
+
 2022-01-16  David Kilzer  <ddkilzer@apple.com>
 

trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm

@@ -246 +246 @@
         if (device.removable)
         {
-            [externalGPUs.get() addObject:device];
+            [externalGPUs addObject:device];
         }
         else if (device.lowPower)
         {
-            [integratedGPUs.get() addObject:device];
+            [integratedGPUs addObject:device];
         }
         else
         {
-            [discreteGPUs.get() addObject:device];
+            [discreteGPUs addObject:device];
         }
     }