Changeset 288232 in webkit

Timestamp:

Jan 19, 2022, 12:38:21 PM (5 years ago)

Author:

Chris Dumez

Message:

WebKit::DownloadProxy::publishProgress() falls through ASSERT_NOT_REACHED()
​https://bugs.webkit.org/show_bug.cgi?id=234975
<rdar://problem/87265153>

Reviewed by Darin Adler.

• UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::publishProgress):
Let's not send the IPC if we failed to create the handle since the recipient code early returns when the handle is
invalid.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Downloads/DownloadProxy.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2022-01-19  Chris Dumez  <cdumez@apple.com>
+
+        WebKit::DownloadProxy::publishProgress() falls through ASSERT_NOT_REACHED()
+        https://bugs.webkit.org/show_bug.cgi?id=234975
+        <rdar://problem/87265153>
+
+        Reviewed by Darin Adler.
+
+        * UIProcess/Downloads/DownloadProxy.cpp:
+        (WebKit::DownloadProxy::publishProgress):
+        Let's not send the IPC if we failed to create the handle since the recipient code early returns when the handle is
+        invalid.
+
 2022-01-19  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WebKit/UIProcess/Downloads/DownloadProxy.cpp

@@ -107 +107 @@
         return;
 
-    SandboxExtension::Handle handle;
-    if (auto createdHandle = SandboxExtension::createHandle(URL.fileSystemPath(), SandboxExtension::Type::ReadWrite))
-        handle = WTFMove(*createdHandle);
-    else
-        ASSERT_NOT_REACHED();
-
-    m_dataStore->networkProcess().send(Messages::NetworkProcess::PublishDownloadProgress(m_downloadID, URL, handle), 0);
+    auto handle = SandboxExtension::createHandle(URL.fileSystemPath(), SandboxExtension::Type::ReadWrite);
+    ASSERT(handle);
+    if (!handle)
+        return;
+
+    m_dataStore->networkProcess().send(Messages::NetworkProcess::PublishDownloadProgress(m_downloadID, URL, *handle), 0);
 }
 #endif // PLATFORM(COCOA)