Changeset 288265 in webkit

Timestamp:

Jan 19, 2022, 6:40:37 PM (5 years ago)

Author:

ysuzuki@apple.com

Message:

[libpas] Disable PAS_ASSERT on Darwin ARM64 (not in ARM64E)
​https://bugs.webkit.org/show_bug.cgi?id=235349

Reviewed by Saam Barati.

We have several weak devices which only have ARM64 (not ARM64E).
And in such a weak device, PAS_ASSERT affects on performance.
By disabling PAS_ASSERT, we got 0.5% improvement in PLT in iPhone 6S.

• libpas/src/libpas/pas_config.h:
• libpas/src/libpas/pas_config_prefix.h:
• libpas/src/libpas/pas_internal_config.h:
• libpas/src/libpas/pas_platform.h:
• libpas/src/libpas/pas_utils.h:

Location:

trunk/Source/bmalloc

Files:

• ChangeLog (modified) (1 diff)
• libpas/src/libpas/pas_config.h (modified) (1 diff)
• libpas/src/libpas/pas_config_prefix.h (modified) (2 diffs)
• libpas/src/libpas/pas_internal_config.h (modified) (1 diff)
• libpas/src/libpas/pas_platform.h (modified) (1 diff)
• libpas/src/libpas/pas_utils.h (modified) (1 diff)

trunk/Source/bmalloc/ChangeLog

@@ +1 @@
+2022-01-19  Yusuke Suzuki  <ysuzuki@apple.com>
+
+        [libpas] Disable PAS_ASSERT on Darwin ARM64 (not in ARM64E)
+        https://bugs.webkit.org/show_bug.cgi?id=235349
+
+        Reviewed by Saam Barati.
+
+        We have several weak devices which only have ARM64 (not ARM64E).
+        And in such a weak device, PAS_ASSERT affects on performance.
+        By disabling PAS_ASSERT, we got 0.5% improvement in PLT in iPhone 6S.
+
+        * libpas/src/libpas/pas_config.h:
+        * libpas/src/libpas/pas_config_prefix.h:
+        * libpas/src/libpas/pas_internal_config.h:
+        * libpas/src/libpas/pas_platform.h:
+        * libpas/src/libpas/pas_utils.h:
+
 2022-01-18  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/bmalloc/libpas/src/libpas/pas_config.h

@@ -39 +39 @@
 #endif
 
+#if PAS_OS(DARWIN) && __PAS_ARM64 && !__PAS_ARM64E && defined(NDEBUG)
+#define PAS_ENABLE_ASSERT 0
+#else
+#define PAS_ENABLE_ASSERT 1
+#endif
 #define PAS_ENABLE_TESTING __PAS_ENABLE_TESTING
 

trunk/Source/bmalloc/libpas/src/libpas/pas_config_prefix.h

@@ -23 +23 @@
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 
  */
+
+#ifndef PAS_CONFIG_PREFIX_H
+#define PAS_CONFIG_PREFIX_H
+
+#include "pas_platform.h"
 
 #if defined(ENABLE_PAS_TESTING)
@@ -55 +60 @@
 #define __PAS_RISCV 0
 #endif
+
+#endif /* PAS_CONFIG_PREFIX_H */

trunk/Source/bmalloc/libpas/src/libpas/pas_internal_config.h

@@ -28 +28 @@
 
 #include "pas_config.h"
-#include "pas_platform.h"
 
 #define PAS_SUBPAGE_SIZE                 4096

trunk/Source/bmalloc/libpas/src/libpas/pas_platform.h

@@ -33 +33 @@
 #endif
 
+/* PAS_COMPILER() - the target compiler */
 #define PAS_COMPILER(FEATURE) (defined PAS_COMPILER_##FEATURE  && PAS_COMPILER_##FEATURE)
 

trunk/Source/bmalloc/libpas/src/libpas/pas_utils.h

@@ -201 +201 @@
 #define PAS_ASSERT(exp) \
     do { \
+        if (!PAS_ENABLE_ASSERT) \
+            break; \
         if (PAS_LIKELY(exp)) \
             break; \