Changeset 288441 in webkit

Timestamp:

Jan 24, 2022, 8:03:50 AM (5 years ago)

Author:

youenn@apple.com

Message:

AVAudioSessionCaptureDeviceManager is not always computing the right default input device
​https://bugs.webkit.org/show_bug.cgi?id=235362
<rdar://87707090>

Addressing post commit comments.

Reviewed by Eric Carlson and Geoff Garen.

• platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:

Fixed the release logging.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-01-24  Youenn Fablet  <youenn@apple.com>
+
+        AVAudioSessionCaptureDeviceManager is not always computing the right default input device
+        https://bugs.webkit.org/show_bug.cgi?id=235362
+        <rdar://87707090>
+
+        Addressing post commit comments.
+
+        Reviewed by Eric Carlson and Geoff Garen.
+
+        * platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm:
+        Fixed the release logging.
+
 2022-01-24  Antoine Quint  <graouts@webkit.org>
 

trunk/Source/WebCore/platform/mediastream/ios/AVAudioSessionCaptureDeviceManager.mm

@@ -238 +238 @@
 {
     auto *defaultInput = [m_audioSession currentRoute].inputs.firstObject;
-    if (!defaultInput)
+    if (!defaultInput) {
+        RELEASE_LOG_INFO(WebRTC, "AVAudioSessionCaptureDeviceManager using previous default input");
         defaultInput = m_lastDefaultMicrophone.get();
-    else {
-        RELEASE_LOG_INFO(WebRTC, "AVAudioSessionCaptureDeviceManager using previous default input");
+    } else
         m_lastDefaultMicrophone = defaultInput;
-    }
+
     auto availableInputs = [m_audioSession availableInputs];