Changeset 288522 in webkit

Timestamp:

Jan 24, 2022, 5:56:26 PM (5 years ago)

Author:

Russell Epstein

Message:

Cherry-pick r288303. rdar://problem/87836127

[:has pseudo-class] Support :has(:not(foo))
​https://bugs.webkit.org/show_bug.cgi?id=235399

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/css/selectors/invalidation/has-with-not-expected.txt: Added.
• web-platform-tests/css/selectors/invalidation/has-with-not.html: Added.

Source/WebCore:

This already works except for a filter bug.

Test: imported/w3c/web-platform-tests/css/selectors/invalidation/has-with-not.html

• style/HasSelectorFilter.h: (WebCore::Style::HasSelectorFilter::reject const):

We shouldn't reject a selector if we have a null key.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@288303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:

branches/safari-613-branch

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-with-not-expected.txt (added)
• LayoutTests/imported/w3c/web-platform-tests/css/selectors/invalidation/has-with-not.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/style/HasSelectorFilter.h (modified) (1 diff)

branches/safari-613-branch/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2022-01-24  Alan Coon  <alancoon@apple.com>
+
+        Cherry-pick r288303. rdar://problem/87836127
+
+    [:has pseudo-class] Support :has(:not(foo))
+    https://bugs.webkit.org/show_bug.cgi?id=235399
+    
+    Reviewed by Darin Adler.
+    
+    LayoutTests/imported/w3c:
+    
+    * web-platform-tests/css/selectors/invalidation/has-with-not-expected.txt: Added.
+    * web-platform-tests/css/selectors/invalidation/has-with-not.html: Added.
+    
+    Source/WebCore:
+    
+    This already works except for a filter bug.
+    
+    Test: imported/w3c/web-platform-tests/css/selectors/invalidation/has-with-not.html
+    
+    * style/HasSelectorFilter.h:
+    (WebCore::Style::HasSelectorFilter::reject const):
+    
+    We shouldn't reject a selector if we have a null key.
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2022-01-20  Antti Koivisto  <antti@apple.com>
+
+            [:has pseudo-class] Support :has(:not(foo))
+            https://bugs.webkit.org/show_bug.cgi?id=235399
+
+            Reviewed by Darin Adler.
+
+            * web-platform-tests/css/selectors/invalidation/has-with-not-expected.txt: Added.
+            * web-platform-tests/css/selectors/invalidation/has-with-not.html: Added.
+
 2022-01-24  Alan Coon  <alancoon@apple.com>
 

branches/safari-613-branch/Source/WebCore/ChangeLog

@@ +1 @@
+2022-01-24  Alan Coon  <alancoon@apple.com>
+
+        Cherry-pick r288303. rdar://problem/87836127
+
+    [:has pseudo-class] Support :has(:not(foo))
+    https://bugs.webkit.org/show_bug.cgi?id=235399
+    
+    Reviewed by Darin Adler.
+    
+    LayoutTests/imported/w3c:
+    
+    * web-platform-tests/css/selectors/invalidation/has-with-not-expected.txt: Added.
+    * web-platform-tests/css/selectors/invalidation/has-with-not.html: Added.
+    
+    Source/WebCore:
+    
+    This already works except for a filter bug.
+    
+    Test: imported/w3c/web-platform-tests/css/selectors/invalidation/has-with-not.html
+    
+    * style/HasSelectorFilter.h:
+    (WebCore::Style::HasSelectorFilter::reject const):
+    
+    We shouldn't reject a selector if we have a null key.
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@288303 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2022-01-20  Antti Koivisto  <antti@apple.com>
+
+            [:has pseudo-class] Support :has(:not(foo))
+            https://bugs.webkit.org/show_bug.cgi?id=235399
+
+            Reviewed by Darin Adler.
+
+            This already works except for a filter bug.
+
+            Test: imported/w3c/web-platform-tests/css/selectors/invalidation/has-with-not.html
+
+            * style/HasSelectorFilter.h:
+            (WebCore::Style::HasSelectorFilter::reject const):
+
+            We shouldn't reject a selector if we have a null key.
+
 2022-01-24  Alan Coon  <alancoon@apple.com>
 

branches/safari-613-branch/Source/WebCore/style/HasSelectorFilter.h

@@ -49 +49 @@
 
     bool reject(const CSSSelector& hasSelector) const { return reject(makeKey(hasSelector)); }
-    bool reject(Key key) const { return !m_filter.mayContain(key); }
-
+    bool reject(Key key) const { return key && !m_filter.mayContain(key); }
 
 private: