Changeset 288933 in webkit

Timestamp:

Feb 1, 2022, 5:41:26 PM (5 years ago)

Author:

Simon Fraser

Message:

Crash under ScrollingCoordinatorMac::hasNodeWithAnimatedScrollChanged()
​https://bugs.webkit.org/show_bug.cgi?id=235989
<rdar://87402941>

Reviewed by Wenson Hsieh.

Crash data suggest that m_scrollingCoordinator can be null in ThreadedScrollingTree::hasNodeWithAnimatedScrollChanged(),
which is true if the scrolling tree keeps ThreadedScrollingTree alive longer than the scrolling coordinator.

As in the other functions in this file, early return if m_scrollingCoordinator is null.

• page/scrolling/ThreadedScrollingTree.cpp:

(WebCore::ThreadedScrollingTree::hasNodeWithAnimatedScrollChanged):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/scrolling/ThreadedScrollingTree.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2022-02-01  Simon Fraser  <simon.fraser@apple.com>
+
+        Crash under ScrollingCoordinatorMac::hasNodeWithAnimatedScrollChanged()
+        https://bugs.webkit.org/show_bug.cgi?id=235989
+        <rdar://87402941>
+
+        Reviewed by Wenson Hsieh.
+
+        Crash data suggest that m_scrollingCoordinator can be null in ThreadedScrollingTree::hasNodeWithAnimatedScrollChanged(),
+        which is true if the scrolling tree keeps ThreadedScrollingTree alive longer than the scrolling coordinator.
+
+        As in the other functions in this file, early return if m_scrollingCoordinator is null.
+
+        * page/scrolling/ThreadedScrollingTree.cpp:
+        (WebCore::ThreadedScrollingTree::hasNodeWithAnimatedScrollChanged):
+
 2022-02-01  Pablo Saavedra  <psaavedra@igalia.com>
 

trunk/Source/WebCore/page/scrolling/ThreadedScrollingTree.cpp

@@ -378 +378 @@
 void ThreadedScrollingTree::hasNodeWithAnimatedScrollChanged(bool hasNodeWithAnimatedScroll)
 {
+    if (!m_scrollingCoordinator)
+        return;
+
     RunLoop::main().dispatch([scrollingCoordinator = m_scrollingCoordinator, hasNodeWithAnimatedScroll] {
         scrollingCoordinator->hasNodeWithAnimatedScrollChanged(hasNodeWithAnimatedScroll);