Changeset 29005 in webkit

Timestamp:

Dec 27, 2007 2:20:18 PM (16 years ago)

Author:

eric@webkit.org

Message:

Reviewed by Sam.

ASSERT in JavaScriptCore while viewing WICD test case
​http://bugs.webkit.org/show_bug.cgi?id=16626

• kjs/nodes.cpp: (KJS::ForInNode::execute): move KJS_CHECK_EXCEPTION to proper place

Location:

trunk

Files:

• JavaScriptCore/ChangeLog (modified) (1 diff)
• JavaScriptCore/kjs/nodes.cpp (modified) (2 diffs)
• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/js/for-in-exeception-expected.txt (added)
• LayoutTests/fast/js/for-in-exeception.html (added)
• LayoutTests/fast/js/resources/for-in-exeception.js (added)

trunk/JavaScriptCore/ChangeLog

@@ +1 @@
+2007-12-27  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Sam.
+
+        ASSERT in JavaScriptCore while viewing WICD test case
+        http://bugs.webkit.org/show_bug.cgi?id=16626
+        
+        * kjs/nodes.cpp:
+        (KJS::ForInNode::execute): move KJS_CHECK_EXCEPTION to proper place
+
 2007-12-26  Jan Michael Alonzo  <jmalonzo@unpluggable.com>
 

trunk/JavaScriptCore/kjs/nodes.cpp

@@ -3841 +3841 @@
 
   JSValue* e = expr->evaluate(exec);
+  KJS_CHECKEXCEPTION
 
   // For Null and Undefined, we want to make sure not to go through
@@ -3847 +3848 @@
     return exec->setNormalCompletion();
 
-  KJS_CHECKEXCEPTION
   JSObject* v = e->toObject(exec);
   PropertyNameArray propertyNames;

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-12-27  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Sam.
+        
+        ASSERT in JavaScriptCore while viewing WICD test case
+        http://bugs.webkit.org/show_bug.cgi?id=16626
+
+        * fast/js/for-in-exeception-expected.txt: Added.
+        * fast/js/for-in-exeception.html: Added.
+        * fast/js/resources/for-in-exception.js: Added.
+
 2007-12-27  Sam Weinig  <sam@webkit.org>